MarlinFirmware / Configurations

Configurations for Marlin Firmware
https://marlinfw.org
GNU General Public License v3.0
1.98k stars 3.33k forks source link

Added HICTOP 3DP-17 #1064

Open Gadgeteering opened 3 weeks ago

Gadgeteering commented 3 weeks ago

Description

Add configuration files for HICTOP 3DP-17 printer

Gadgeteering commented 3 weeks ago

Built and tested on my HICTOP 3DP-17

thinkyhead commented 3 weeks ago

Thanks for the submission! New configurations must be based on the default configurations from import-2.1.x for inclusion in the next release. The configurations in this PR are targeted to an older version of Marlin, so they will need to be updated to the current version, 02010300.

thinkyhead commented 3 weeks ago

I went ahead and applied the needed updates. Please check to make sure they still work as intended and have all the same changes. One quick way to see all the changes in isolation is to replace the Hictop configs with the default configs, then use GitHub Desktop to view the differences.

Gadgeteering commented 3 weeks ago

line 1601 should read

#define NOZZLE_TO_PROBE_OFFSET { 10, 50, -1} 

I have tried to build the firmware but get error for the code between lines 3212->3215

//#define DGUS_LCD_UI ORIGIN
#if DGUS_UI_IS(MKS)
  #define USE_MKS_GREEN_UI
#elif DGUS_UI_IS(IA_CREALITY)

I am using PlaformIO in visual studio code to build the firmware

thisiskeithb commented 3 weeks ago

I have tried to build the firmware but get error for the code between lines 3212->3215

What's the error? Make sure you're using the latest bugfix-2.1.x.

All changed configs in a PR are built and this PR passed:

image
Gadgeteering commented 3 weeks ago

Thanks for your advice, build and tested on my 3D printer

thisiskeithb commented 3 weeks ago

Thanks for your advice, build and tested on my 3D printer

I assume you closed this PR on accident, so I’ve reopened it.

How’d testing go?

Gadgeteering commented 3 weeks ago

Tested and works