search

MarlinFirmware / Configurations

Configurations for Marlin Firmware
https://marlinfw.org
GNU General Public License v3.0
1.98k stars 3.33k forks source link

🔧 No SDCARD_SORT_ALPHA on Creality CR-6 SE (for now) #1071

Open thisiskeithb opened 1 week ago

thisiskeithb commented 1 week ago

Description

While running the build_all_examples script, this config would not build because SDCARD_SORT_ALPHA was enabled:

#error "SDCARD_SORT_ALPHA requires an LCD that supports it. (It doesn't apply to M20, etc.)"

I see the upstream PR (https://github.com/MarlinFirmware/Marlin/pull/19958) uses this config and is passing upstream CI tests, but it's been open for four years and has caused CI to fail in this (Configurations) repo since we've enabled CI testing on all PRs. If CR-6 SE support is ever merged, we can enable SDCARD_SORT_ALPHA on this config again.

Benefits

Config now builds.

Related Issues

thinkyhead commented 1 week ago

I recently sent my CR-6 SE to my former roommate and helpful friend Luu Lac, and he informs me that the firmware provided by Creality is terrible, so it would be great to get that PR completed with the display/controller support integrated as neatly as we can according to the latest paradigm. In order to make future integration of custom controllers easier, I've started on work to add an ExtUI layer to Ender-3 V2 ProUI. It demonstrates the possibility to integrate more new display/controllers by expanding on the ExtUI methods and replacing special case callbacks with additional ExtUI callbacks.

thisiskeithb commented 1 week ago

I recently sent my CR-6 SE to my former roommate and helpful friend Luu Lac, and he informs me that the firmware provided by Creality is terrible, so it would be great to get that PR completed with the display/controller support integrated as neatly as we can according to the latest paradigm. In order to make future integration of custom controllers easier, I've started on work to add an ExtUI layer to Ender-3 V2 ProUI. It demonstrates the possibility to integrate more new display/controllers by expanding on the ExtUI methods and replacing special case callbacks with additional ExtUI callbacks.

Awesome!

Other than the Ender-5 S1 and CR-6 SE configs needing upstream support, we're almost able to build every config hosted here. Ideally, I'd like to enable CI on direct commits once we reach 100% so it'll be faster / easier to tell when something breaks.