search

MarlinFirmware / Configurations

Configurations for Marlin Firmware
https://marlinfw.org
GNU General Public License v3.0
1.98k stars 3.33k forks source link

🔧 Define Malyan M300 E0_AUTO_FAN_PIN directly (again) #1075

Closed thisiskeithb closed 6 days ago

thisiskeithb commented 1 week ago

Description

I had defined the E0_AUTO_FAN_PIN directly for this config in #1074 to get https://github.com/MarlinFirmware/Marlin/pull/27214 passing CI tests, but the "for now… " commit (92ce6f46f) that was added before #1074 was merged left the config in an unsafe state.

The M300 pins file defines an AUTO_FAN_PIN which does nothing. Without an E0_AUTO_FAN_PIN defined, the hotend cooling fan does not turn on.

Since https://github.com/MarlinFirmware/Marlin/pull/27214 is a work in progress / in the "After 2.1.3" milestone, it leaves this config in an unsafe state and will be broken for 2.1.3.

I can submit another PR that will use the "standard" method of commenting out E0_AUTO_FAN_PIN as intended by the last comment in #1074 if/when https://github.com/MarlinFirmware/Marlin/pull/27214 is ever merged.

Benefits

Malyan M300 config will work / be safe again.

Related Issues

thisiskeithb commented 6 days ago

If https://github.com/MarlinFirmware/Marlin/pull/27216 is merged, this is not needed and can be closed.

thisiskeithb commented 6 days ago

This is no longer needed: https://github.com/MarlinFirmware/Marlin/commit/96e3dfed4620bfd6d2b1a8e9e63f39cc23634630