MarlinFirmware / Marlin

Marlin is an optimized firmware for RepRap 3D printers based on the Arduino platform. Many commercial 3D printers come with Marlin installed. Check with your vendor if you need source code for your specific machine.
https://marlinfw.org
GNU General Public License v3.0
16.14k stars 19.2k forks source link

Sled Mounted Z-axis Endstop for Z-probing (Auto Bed Leveling) #1014

Closed ChuckBell closed 9 years ago

ChuckBell commented 10 years ago

Hello. I have a new design that mounts the Z-axis endstop on a sled that can be docked on the right of the X-axis. I have modified Marlin to support this new feature and while it works, I occasionally encounter a MSG_ERR_KILLED error when using my new dock/undock code.

Is there some way I can send you the difference file and we can discuss the code? Or should I create a fork and put the code there?

I've posted the thing on Thingiverse: http://www.thingiverse.com/thing:396692.

My contact is d r c h a r l e s b e l l at g m a i l dot c o m

Thanks.

nicolas-rambaud commented 10 years ago

Very nice idea !

De : oliasmage [mailto:notifications@github.com] Envoyé : vendredi 18 juillet 2014 14:42 À : ErikZalm/Marlin Objet : [Marlin] Sled Mounted Z-axis Endstop for Z-probing (Auto Bed Leveling) (#1014)

Hello. I have a new design that mounts the Z-axis endstop on a sled that can be docked on the right of the X-axis. I have modified Marlin to support this new feature and while it works, I occasionally encounter a MSG_ERR_KILLED error when using my new dock/undock code.

Is there some way I can send you the difference file and we can discuss the code? Or should I create a fork and put the code there?

I've posted the thing on Thingiverse: http://www.thingiverse.com/thing:396692.

My contact is d r c h a r l e s b e l l at g m a i l dot c o m

Thanks.

— Reply to this email directly or view it on GitHub https://github.com/ErikZalm/Marlin/issues/1014.[image: Image supprimée par l'expéditeur.]

ChuckBell commented 10 years ago

I have narrowed down the problem. The kill() is being called from @line#3500 in Marlin_main.cpp:

if defined(KILL_PIN) && KILL_PIN > -1

if( 0 == READ(KILL_PIN) )
  kill();

endif

I am using pin 10 for the electromagnet triggering it with

digitalWrite(SERVO0_PIN, HIGH);

and digitalWrite(SERVO0_PIN, LOW);

I also have a RepRapDiscount Graphic LCD.

What could be going wrong for the code to detect the KILL_PIN is getting set?

boelle commented 9 years ago

your initial post: fork marlin and make the changes.... then submit a pull request

boelle commented 9 years ago

maybe the relay board is making so much noise that it triggers the kill,

is it using any diodes to protect against EMF etc etc?

boelle commented 9 years ago

i will close this one as there has not been any activity and the original poster should really just submit a pull request

ChuckBell commented 9 years ago

Hi,

Forgive me. What was I supposed to do? I thought I had. Should I reopen this?

Chuck

Sent from my iPhone

On Apr 26, 2015, at 7:43 AM, Bo Herrmannsen notifications@github.com wrote:

i will close this one as there has not been any activity and the original poster should really just submit a pull request

— Reply to this email directly or view it on GitHub.

AnHardt commented 9 years ago

All is well. The sled-probe is in the code-base for a while. The unbelievable long delay until the kill pin reacts was shortened some weeks ago. We just closed this forgotten issue.

ChuckBell commented 9 years ago

Thanks! :)

Sent from my iPhone

On Apr 26, 2015, at 10:30 AM, AnHardt notifications@github.com wrote:

All is well. The sled-probe is in the code-base for a while. The unbelievable long delay until the kill pin reacts was shortened some weeks ago. We just closed this forgotten issue.

— Reply to this email directly or view it on GitHub.

github-actions[bot] commented 2 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.