search

MarlinFirmware / Marlin

Marlin is an optimized firmware for RepRap 3D printers based on the Arduino platform. Many commercial 3D printers come with Marlin installed. Check with your vendor if you need source code for your specific machine.
https://marlinfw.org
GNU General Public License v3.0
16.3k stars 19.25k forks source link

MONITOR_DRIVER_STATUS should work for tmc2660 #12362

Closed alexxy closed 6 years ago

alexxy commented 6 years ago

With latest bugfox-2.0.x TMC drivers conditions seems changed and now bans MONITOR_DRIVER_STATUS for tmc2660

error: #error "MONITOR_DRIVER_STATUS requires at least one TMC2130 or TMC2208."
#error "MONITOR_DRIVER_STATUS requires at least one TMC2130 or TMC2208."
teemuatlut commented 6 years ago

Yes.

alexxy commented 6 years ago

???

Ludy87 commented 6 years ago

tmc2660 is not supported for MONITOR_DRIVER_STATUS

teemuatlut commented 6 years ago

tmc2660 is not supported for MONITOR_DRIVER_STATUS

Actually it is.

MONITOR_DRIVER_STATUS should work for tmc2660

"Yes."

Ludy87 commented 6 years ago

Sorry, I confused it with DEBUG https://github.com/MarlinFirmware/Marlin/blob/525ea554a1e53cef7d60dfa8d33664a99bcd4a3f/Marlin/src/feature/tmc_util.cpp#L102 https://github.com/MarlinFirmware/Marlin/blob/525ea554a1e53cef7d60dfa8d33664a99bcd4a3f/Marlin/src/feature/tmc_util.cpp#L103

thinkyhead commented 6 years ago

Patched sanity-check to permit TMC2660.

github-actions[bot] commented 4 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.