MarlinFirmware / Marlin

Marlin is an optimized firmware for RepRap 3D printers based on the Arduino platform. Many commercial 3D printers come with Marlin installed. Check with your vendor if you need source code for your specific machine.
https://marlinfw.org
GNU General Public License v3.0
16.29k stars 19.24k forks source link

RepRap Discount Full Graphics LCD Bootup screen not correctly displayed. #1337

Closed JoshyuNL closed 9 years ago

JoshyuNL commented 9 years ago

So this is really a non-issue and something that has the lowest priority of all things I would think.

But just thought I would document it now that I've noticed it. While the printer is booting up, it show the new Marlin logo on the left and some notes on the right. On my display these two columns seem to be separated by a thick vertical line which cuts off part of both columns.

My guess is that the scaling is off or that that vertical line should not be there at all. It looks like it doesn't really reach the bottom of the sceen either, since the last line of text on the right goes a few pixels lower. It does seem to go all the way to the top.

wp_20150108_23_28_40_smart 2 1

boelle commented 9 years ago

it was me that changed the logo, the line should not be there

if you look in DOGMbitmaps.h file there is a link to the online site i used to convert from png to hex

i have no clue where the line comes from

boelle commented 9 years ago

Q: where is the info on the right stored? in the same file as hex?

boelle commented 9 years ago

maybe there is a clue in this:

define START_BMPWIDTH 60 //Width in pixels - http://www.digole.com/tools/PicturetoC_Hex_converter.php

define START_BMPHEIGHT 64 //Height in pixels

define START_BMPBYTEWIDTH 8 //Width in bytes

const unsigned char start_bmp[574] PROGMEM = { //AVR-GCC, WinAVR 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x0f,

i did not change those values and they might be wrong now that the logo is changed?

boelle commented 9 years ago

try and download that single file and flash firmware again, does it look better now? just changed it

DOGMbitmaps.h is the one to go for

boelle commented 9 years ago

found the file where info on the right is defined... will update that a bit

boelle commented 9 years ago

should we keep the lower part of the right?

or just have marlin and ver. no ?

boelle commented 9 years ago

one argument for reducing the info to bare minimum is that this is something that will reduce code size... not by much but everything counts

stv0g commented 9 years ago

Bo,

did you removed the padding/whitespace from the logo before converting it to HEX?

Looks like there are the same whitespace like in the GitHub Organization Logo. I added another version of the Logo without the padding/whitespace. This one is called „Marlin Logo GitHub.png“ and is used by README.md.

For the firmware splash screen we should use the version without whitespace/padding.

Steffen Vogel Robensstraße 69 52070 Aachen

Mail: post@steffenvogel.de Mobil: +49 1575 7180927 Web: http://www.steffenvogel.de Jabber: steffen.vogel@jabber.rwth-aachen.de

Am 09.01.2015 um 12:58 schrieb Bo Herrmannsen notifications@github.com:

should we keep the lower part of the right?

or just have marlin and ver. no ?

— Reply to this email directly or view it on GitHub.

boelle commented 9 years ago

i just did remove as much padding arround the logo as i could this morning and updated the file

boelle commented 9 years ago

i was going to commit the logo but you have beat me to it

JoshyuNL commented 9 years ago

The new file does change it a bit. But it's still not fully fixed. The logo moved to the top and the thick line is still there where the logo is.

image

stv0g commented 9 years ago

The „fitted“ logo I’ve committed still a 3-5 pixel transparent border.

I’dont know if we should remove this too for the splashscreen.

Steffen Vogel Robensstraße 69 52070 Aachen

Mail: post@steffenvogel.de Mobil: +49 1575 7180927 Web: http://www.steffenvogel.de Jabber: steffen.vogel@jabber.rwth-aachen.de

Am 09.01.2015 um 13:07 schrieb Bo Herrmannsen notifications@github.com:

i was going to commit the logo but you have beat me to it

— Reply to this email directly or view it on GitHub.

boelle commented 9 years ago

try remove that too.. the vertical line is 4 pixels

ErikZalm commented 9 years ago

If you are changing the Logo then also remove ErikZalm.

boelle commented 9 years ago

oki doki... my idea:

strike ErikZalm and replace it with Marlin

strike DOFM128 and replace with ver info

strike everything else

boelle commented 9 years ago

download dogm_lcd_implementation.h also

how does the ver info side come up?

JoshyuNL commented 9 years ago

Like this:

wp_20150109_13_20_58_smart 1

Maybe, if this is all the info we would want on the splash screen, try adding the marlin logo in the center and put the text below it? I have no more time to test right now, will take another look here tomorrow.

boelle commented 9 years ago

ok.... thanks anyway....

have an idea on how to move down the logo again ... and then we just need to remove the bit of vertical line

stv0g commented 9 years ago

Hi,

I rewrote this splashscreen. But unfortunatly I'm unable to test it without hardware.

Take a look in my repo: https://github.com/stv0g/Marlin/tree/LogoLCD/

I would be happy about some feedback before merging it into the official repo

alexborro commented 9 years ago

Sorry my ignorance, how do you guys convert the image to hex? Em 09/01/2015 16:25, "Steffen Vogel" notifications@github.com escreveu:

Hi,

I rewrote this splashscreen. But unfortunatly I'm unable to test it without hardware.

Take a look in my repo: https://github.com/stv0g/Marlin/tree/LogoLCD/

I would be happy aboit some feedbackbefore merging it into the official repo

— Reply to this email directly or view it on GitHub https://github.com/MarlinFirmware/Marlin/issues/1337#issuecomment-69375927 .

boelle commented 9 years ago

http://www.digole.com/tools/PicturetoC_Hex_converter.php

stv0g commented 9 years ago

@JoshyuNL Can you test my version? Please note, that there are 3 new Configuration variables in Configuration.h.

https://github.com/stv0g/Marlin/tree/LogoLCD/

Please also try it once with: #define START_BMPHIGH 1 in Configuration.h This is a high resolution version of the boot screen logo. I just want to see if not variants are working before pushing this to the main repo.

Thanks :-)

Shrikant888 commented 8 years ago

Hello All! What is meant by "const unsigned char start_bmp[574] PROGMEM". In this what is 574? I know it may be arrary size. But how come 574 only. Please reply.

thinkyhead commented 8 years ago

@Shrikant888

This particular array stores the bitmap data for the boot screen.

If you look at the newer code you will see that the arrays for the bitmap (and the custom bitmap) is 512 bytes, which corresponds to the dimensions of the screen. I'm not sure what the extra 62 bytes were for in the older code.

Shrikant888 commented 8 years ago

Please let me ask again sir. I have designed my own 128x64 resolution logo and I wanted to display it. So, process will be like first my 128x64 logo will have to come and then regular REPRAP logo should come. I am not changing REPRAP and then rest will be same. What changes I should make in dogm_lcd_implementation.h and in DOGMbits.h.. Please tell.

thinkyhead commented 8 years ago

See the files in Marlin/example_configurations/Hephestos_2 for an example of making a custom boot screen, with links to the tools used.

github-actions[bot] commented 2 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.