search

MarlinFirmware / Marlin

Marlin is an optimized firmware for RepRap 3D printers based on the Arduino platform. Many commercial 3D printers come with Marlin installed. Check with your vendor if you need source code for your specific machine.
https://marlinfw.org
GNU General Public License v3.0
16.19k stars 19.22k forks source link

[BUG] TMC5160 is compiling without errors without CS pins defined #13734

Closed Svatevit closed 4 years ago

Svatevit commented 5 years ago

Description

I just installed TMC5160 on E0 and tried to compile firmware. It did without errors, but it's not working. When I changed E0 to TMC2130 in code, it says I don't have CS E0 pin defined.

Steps to Reproduce

Remove/comment E0_CS_PIN from pin definitions, set TMC5160 as driver for E0.

Expected behavior: [E0_CS_PIN not defined error]

Actual behavior: [Compilation finishes succesfuly, printer dead]

teemuatlut commented 5 years ago

Yea looks like the sanitychecks are only for TMC2130. If you don't define it, Marlin will assign -1 for the pin and there won't be a compile error from a missing define.

boelle commented 5 years ago

Lack of Activity This issue is being closed due to lack of activity. If you have solved the issue, please let us know how you solved it. If you haven't, please tell us what else you've tried in the meantime, and possibly this issue will be reopened.

InsanityAutomation commented 5 years ago

This may be valid as some installations bring the pin directly to ground instead of software controlling it to make it work from my understanding. @teemuatlut In your opinion should a sanity check be added?

boelle commented 4 years ago

i add the confirmed label as it seems pretty clear that we need the sanity check

boelle commented 4 years ago

pr has been merged so should be fixed

github-actions[bot] commented 4 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.