search

MarlinFirmware / Marlin

Marlin is an optimized firmware for RepRap 3D printers based on the Arduino platform. Many commercial 3D printers come with Marlin installed. Check with your vendor if you need source code for your specific machine.
https://marlinfw.org
GNU General Public License v3.0
16.18k stars 19.21k forks source link

[BUG] Marlin 2.0 MKS Sbase Missing Pin Macro? #14837

Closed MicrowavedBread closed 5 years ago

MicrowavedBread commented 5 years ago

Description

While trying to save the program it gives the errors:

Missing binary operator before token "(" on lines 137:12, 161:12, 266:15, and 289:15

http://prntscr.com/oo4ws4

It happens wit the latest release and the one in the zip file I attached. I read in another post that the macro "LPC1768_PIN_INTERRUPT" was accidentally removed and i guess not put back in since October. https://github.com/MarlinFirmware/Marlin/issues/12166

Steps to Reproduce

  1. Change to MKS Sbase board
  2. Try to save or compile
p3p commented 5 years ago

You need to supply your configs and probably the pins file you are using, you forgot to attach the zip file you mention.

The issue you linked was fixed long ago, and all our tests are passing so its something you are changing for your setup.

MicrowavedBread commented 5 years ago

Config and pin files.zip

Sorry, i must have accidentally deleted it

p3p commented 5 years ago

All 3 of these files are very out of date, you will need to transfer your settings from them into the current versions.

This was the first error when I tried to build: Marlin/src/HAL/HAL_LPC1768/../../core/../inc/SanityCheck.h:374:4: error: #error "LPC_SD_(LCD|ONBOARD|CUSTOM_CABLE) are now SDCARD_CONNECTION. Please update your Configuration_adv.h."

After seeing this I did a diff between your files and the current ones and it showed considerable changes not related to your settings.

MicrowavedBread commented 5 years ago

Marlin.zip I'm getting the same issue on the latest version from github

thinkyhead commented 5 years ago

I read in another post that the macro "LPC1768_PIN_INTERRUPT" was accidentally removed and i guess not put back in since October.

According to my reading of that issue, LPC1768_PIN_INTERRUPT_M is now part of the framework so we don't need to define it.

p3p commented 5 years ago

What IDE are you using and how long has it been since you updated your libraries, frameworks / platforms? You need to keep them up to date. (although I haven't changed anything in so long I almost forgot to mention it)

MicrowavedBread commented 5 years ago

I'm using Platformio in Atom. And everything is up to date as far as i can tell

thinkyhead commented 5 years ago

Please use Visual Studio Code. PlatformIO is no longer supporting Atom.

p3p commented 5 years ago

If you're up to date, when you click platformio->update platforms packages and libraries it should show 

Platform NXP Arduino LPC176x
--------
Updating nxplpc-arduino-lpc176x          @ 0.0.1          [Detached]
Updating toolchain-gccarmnoneeabi        @ 1.80201.181220 [Up-to-date]
Updating tool-pyocd                      @ 0.801.0        [Up-to-date]
Updating framework-arduino-lpc176x       @ 0.1.3          [Up-to-date]

Also what thinkyhead said.

thinkyhead commented 5 years ago

Successfully built MKS SBASE test configurations. No issues.

MicrowavedBread commented 5 years ago

Im getting the same issue in visual studio code http://prntscr.com/ooc4oq

And yes, its all up to date

MicrowavedBread commented 5 years ago

I deleted both of my modified marlin folders and grabbed a completely untouched fresh one and it still gives the same errors

p3p commented 5 years ago

can you test with the minimum changes, so a fresh download and just set the motherboard.

MicrowavedBread commented 5 years ago

can you test with the minimum changes, so a fresh download and just set the motherboard.

For some reason the mks sbase board isnt on the one i just downloaded. I don't think im that blind

github-actions[bot] commented 4 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.