MarlinFirmware / Marlin

Marlin is an optimized firmware for RepRap 3D printers based on the Arduino platform. Many commercial 3D printers come with Marlin installed. Check with your vendor if you need source code for your specific machine.
https://marlinfw.org
GNU General Public License v3.0
16.22k stars 19.22k forks source link

[BUG] Z raised again and again. #16395

Closed PNech closed 4 years ago

PNech commented 4 years ago

Z raised again and again before individual homing X or Y.

Firmware: Marlin bugfix 2.0.x

Configuration.zip

sjasonsmith commented 4 years ago

Can you add more information to this? We need to know exactly what the unexpected behavior is, along with steps to reproduce it.

tatusah commented 4 years ago

I guess it's about raise z before homing which happens every time if you home axis individually. So basically every time you home x or y axis the z position climbs up (reproduce by turning on the printer and just home x or y axis multiple times). So maybe there could be done some kind of check if the z axis has already been raised once. However, if you just home all axis at the same time then this isn't an issue. And probably you don't have to home individual axis multiple times anyway. I think only situations where this can cause problem is if the z height is close to the movement limit to start with.

PNech commented 4 years ago

I installed SKR 1.3 on my printer 4 months ago and installed Marlin-bugfix-2.0.x. I worked well. Now I checked marlin.org and saw a new version. I download it and configure, printer work well too, but I find bug with individual homing.

sjasonsmith commented 4 years ago

I find bug with individual homing.

Can you provide specific steps to reproduce the problem?

I suspect @tatusah is probably correct, and I probably introduced that behavior recently. We need you to provide more specific details of the problem to make sure it can be fixed correctly.

tatusah commented 4 years ago

I can confirm this happening with Z_HOMING_HEIGHT defined. I've it set to 5 currently and every individual x or y axis homing incrementally lifts the carriage 5 mm on Ender 3 with SKR e3 mini v1.2. And @PNechNET has the homing height set 10 so he must see the height change by 10 every homing cycle.

sjasonsmith commented 4 years ago

@tatusah, I understand the issue as you describe it. I’m just trying to get the original poster to provide appropriate details. If I or anybody else is going to spend time fixing it, it seems reasonable to expect the reporter to provide a good description of the problem.

PNech commented 4 years ago

Thanks to @tatusah, this problem occurs if the Z axis is unexpected, if you first determine Z, the problem disappears. My standard "Z_HOMING_HEIGHT" is 10, I set 5, the result is a decrease in lift height.

@sjasonsmith My steps: 1) I downloaded the firmware from the site 2) Manually transferred the settings from the old firmware to the new one (without copying files) 3) Installed the firmware on my printer with skr 1.3. 3) Turned on my printer and started checking all axes separately. 4) Checked the correct direction of movement, began to check the limit switches. At this moment I found this error. I downloaded the firmware 4 days ago. The configuration files are in the description of the first comment.

sjasonsmith commented 4 years ago

Thanks. This is something I introduced recently. I was fixing an issue that could cause the nozzle to scrape across the bed if homing after motors have been disabled. If the Z position is not known, Z will be raised.

To fix this, the code will need to remember a relative positions since the motors were enabled. I’m not sure whether that already exists, or if more state variables will be needed.

github-actions[bot] commented 4 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.