search

MarlinFirmware / Marlin

Marlin is an optimized firmware for RepRap 3D printers based on the Arduino platform. Many commercial 3D printers come with Marlin installed. Check with your vendor if you need source code for your specific machine.
https://marlinfw.org
GNU General Public License v3.0
16.21k stars 19.22k forks source link

[BUG] Broken babystepping #16941

Closed sismo99 closed 4 years ago

sismo99 commented 4 years ago

Bug Description

After updating to Latest Marlin 2.0.4.1 and later to the latest bugfix (23-02-2020) when i try to adjust my z offset with the babytep function the nozzle does not move to any direction (up or down) the values goes up or down but the nozzle does not move

when not printig i can go to the move axis menu and it does move well but not in the babysteping function, also y can adjust the z offset with the M851 command (but i have to guess it, print a proof and adjust it like that)

i tried and old build of marlin 2.0.3 (2 Weeks Ago) and worked well so i guess the priblem is in this latest build

My Configurations

Ender-3 Pro SKR Mini E3 1.2 Latest Marlin Bugfix (23-02-2020) EZABL system

VSCode qit PlatformIO

Configuration Files.zip

Steps to Reproduce

  1. Update To The lastest stable or bugfix Marlin
  2. Try to configure your Z-Offset
  3. Start a print and double clic in the dial button
  4. Move the dial to any direction you can se the values change but not the nozzle

Expected behavior: The nozzle move a little up or down

Actual behavior: It does not move nothing

Additional Information

As i say in the move axis menu it moves but not while you are in babystepping

thisiskeithb commented 4 years ago

I had reported it initially in https://github.com/MarlinFirmware/Marlin/issues/16889, but babystepping is still broken using 2bcc2ec ☹️

goofball222 commented 4 years ago

Seeing the same thing here with 2bcc2ec freshly compiled. Back to M211 S0 and negative G1 Z axis moves I go.

brejzek commented 4 years ago

I have the same problem ender 3 pro skr 1.3. Which version to roll back to?

XBrav commented 4 years ago

I have the same problem ender 3 pro skr 1.3. Which version to roll back to?

Marlin 2.0.3 is working fine for me. It's definitely something in 2.0.4 forward.

thisiskeithb commented 4 years ago

Marlin 2.0.3 is working fine for me. It's definitely something in 2.0.4 forward.

There was a bug in 2.0.3 that prevented extruder motors being turned off and also would leave the hotend on stuck on your print near the end if you have status LEDs, so be careful with it.

Kraken3d commented 4 years ago

I also concur. Babysteps are not functional in the latest build. I just finished recompiling my firmware from the previous release and babysteps are no longer working. Just as the original poster had mentioned.

SCiunczyk commented 4 years ago

I have this same problem on megaatmega2560/RAMPS/TMC2130

Minims commented 4 years ago

Same here on SKR Pro with the last bugfix-2.0.x.

thinkyhead commented 4 years ago

I have it working on an LPC1769 now. I'll push a fix soon after I check out the reason why it works.

SCiunczyk commented 4 years ago

Great, I'll test in on my hardware immediately.

thinkyhead commented 4 years ago

Cool. The patch is now pushed to bugfix-2.0.x. The problem was my misunderstanding of how I set up the babystepping array. That was simple to fix.

I also added a "hidden" option at the top of stepper.cpp. Comment out BABYSTEPPING_EXTRA_DIR_WAIT to leave out the extra delays around the last DIR pin change in a babystep. This can make babystepping smoother but less delay might trigger errors with certain Trinamic drivers.

SCiunczyk commented 4 years ago

I can confirm, it's working like a charm on my megaatmega2560/RAMPS/TMC2130. Many thanks @thinkyhead !

Roonster78 commented 4 years ago

I can confirm also on BTT SKR mini E3 V1.2/TMC2209! Thanks @thinkyhead

Powerprobot commented 4 years ago

I can confirm working on BTT SKR1.3 with TMC2208 Uart Stealthchop Mode! great work! Thanks @thinkyhead

thinkyhead commented 4 years ago

Good to hear it's working. I did some additional things last week to try to mitigate bad timing shutting down TMC2209 drivers (particularly on SKR boards) so hopefully now that the calls are working again we'll get a chance to do more testing and patching of that issue.

sismo99 commented 4 years ago

i just have the chanceto cimpile the new bigfix and just to confirm that it is working great (i know that it is closed but as posted this i want to confir that it was fixed thanks a lot Thinkyheadkeep with the great work

bill-orange commented 4 years ago

Still appears broken on Melzi board.

larsnordstrom commented 4 years ago

I have the same issue on 2.0.4.4 with Einsy Rambo + PINDA2.

thinkyhead commented 4 years ago

See if BABYSTEPPING_EXTRA_DIR_WAIT helps at all. And then see if INTEGRATED_BABYSTEPPING helps at all.

github-actions[bot] commented 4 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.