MarlinFirmware / Marlin

Marlin is an optimized firmware for RepRap 3D printers based on the Arduino platform. Many commercial 3D printers come with Marlin installed. Check with your vendor if you need source code for your specific machine.
https://marlinfw.org
GNU General Public License v3.0
16.28k stars 19.24k forks source link

[BUG] Ender 3V2 : Adding relative motion to controller menu #18800

Closed fleek closed 4 years ago

fleek commented 4 years ago

Description

Currently, the controller offers the options : Prepare -> Move -> Move X,Y,Z options. However, these moves are absolute. In my previous Anet A8 LCD controller, the move options are relative to the current hotend position.

I don't know in what circumstances will the current absolute move options be useful, but I think relative move options might be more useful to fine-tune the positions of the hotend.

Feature Workflow

  1. Adding relative move options to the controller menu. Keeping the existing absolute move options for X,Y and Z. However, move the Extruded option to the new relative option menu.
  2. Change the current move option to be more intuitive to specify 'Move Absolute' instead of 'Move'
  3. Include menu option under Prepare -> Move relative -> Move relative X,Y,Z, E The relative moves will be governed by the soft endstops if turned on. The registered current coordinates of X,Y,Z position will be display and the relative move distance can be selected. I have not decided on the menu design yet.

Additional Information

I can help work on this feature. However, I would need tools to edit the icon files from the DWIN DGUS if someone can point me where to obtain them. It will take me sometime to implement this feature as I cannot commit full time to this feature, any help will be appreciated.

sjasonsmith commented 4 years ago

I removed the "Feature Request" label because I thought surely you were mistaken. The moves on the LCD are always relative.

Now I see that you are saying this is the Ender 3 V2 display. Jogging moves do not sound useful if they are absolute, but it still seems like surely this is a bug, and not a feature request.

I think we need more information to understand the problem, and for more V2 users to verify the behavior.

Pictures of the menu which causes problems would be helpful.

sjasonsmith commented 4 years ago

Admittedly, I know so little about this display that I don't know whether Marlin controls what is on that display, or if it is being controlled by separate display firmware.

fleek commented 4 years ago

@sjasonsmith After autohoming, when you navigate to the menu option Prepare->Motion, you will see the following numbers being shown on the X,Y and Z. I think this proves that it is absolute rather than relative, if it is relative, all the values should be zero right?

IMG_20200728_122947

sjasonsmith commented 4 years ago

@fleek I've never used that interface. I assume that if you tap "MoveX" you are then provided a means to adjust that in small relative units. But again, I've not used it, so maybe not!

boelle commented 4 years ago

@fleek please edit your title and replace [FR] with [BUG]

fleek commented 4 years ago

@sjasonsmith In the dwin.cpp file, under the HMI_Move_X subroutine : current_position[X_AXIS] = HMI_ValueStruct.Move_X_scale / 10; If I am not wrong, it is a absolute position move.

sjasonsmith commented 4 years ago

@fleek I am not doing anything with this issue. I do not have the hardware to attempt to help.

cosmoderp commented 4 years ago

I actually plan to add this to DWIN.cpp as part of my menus overall that I am working on but as an option you have to enable. I have made some menu changes already but I have to work too so its a bit slow.

github-actions[bot] commented 4 years ago

This issue is stale because it has been open 30 days with no activity. Remove stale label / comment or this will be closed in 5 days.

github-actions[bot] commented 4 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.