MarlinFirmware / Marlin

Marlin is an optimized firmware for RepRap 3D printers based on the Arduino platform. Many commercial 3D printers come with Marlin installed. Check with your vendor if you need source code for your specific machine.
https://marlinfw.org
GNU General Public License v3.0
16.25k stars 19.23k forks source link

Ender 3v2 - DWIN_SET - "1.English.jpg" not updating during flash #18825

Closed mjmurray68 closed 4 years ago

mjmurray68 commented 4 years ago

Bug Description

When flashing DWIN_SET from the current Configuration for Ender V2, the display menu does not reflect the menu changes in the 1.English.jpg file. Specifically the "Store Configuration" menu item:

image

After flashing, the menu item remains "Storage configuration" although the image selection being made from dwin.ccp appears to be correct as the word "Storage" is being cut off:

image image

My Configurations

Configs.zip

Steps to Reproduce

  1. Copy latest "DWIN_Set Folder from Ender 3 V2 Configurations to root of SD Card
  2. Insert SD card into Display SD Slot
  3. Power on Printer
  4. Wait for Blue Screen to Turn Orange.
  5. Power off Printer/Remove SD Card
  6. Power on Printer/Navigate to Control Menu

Expected behavior: [What you expect to happen] Expect "Storage Configuration" menu item to be changed to "Store configuration"

Actual behavior: [What actually happens] Menu Item does not change after flash.

Additional Information

Available as requested.

fleek commented 4 years ago

I don't think updating the .jpg file without recompiling the .bin file will work. I believe you need a tool to combine the icon files and .jpgs into the bin file which is updated into the DWIN DGUS device.

mjmurray68 commented 4 years ago

@fleek I totally concur, but I didn't update the image, it was part of the Configurations release. So it may mean that the .bin file for the display, in the DWIN_SET directory hasn't been recompiled in the current Configurations release.

fleek commented 4 years ago

@mjmurray68 Yes, there is no clarified workflow for updating the DWIN DGUS menu pages and icons, though some people have figured out how to update it, but they are not sharing. I have visited the DWIN DGUS website and downloaded tools to try to change the icons and amend the messages but to no avail. It will probably take some time. So hopefully you can live with this minor inconvenience atm until we figure out the tools required. Even writing to Creality has not been forthcoming in supporting my endeavor. I read Chinese and there are a lot of other messages in Chinese such as 'The filament has run out blah blah blah' which is not in the English message jpg. I was translating that as well.

mjmurray68 commented 4 years ago

@fleek Absolutely can live with it! I just wanted to make sure, given that the image changed, that the intent wasn't to have an updated DWIN DGUS bin as part of the release, and have it not working.

And thanks btw!

fleek commented 4 years ago

@mjmurray68 Sorry for having misled you but the developers and contributors are all still figuring out this DWIN DGUS thingy. Hopefully we can get more info and people with the knowledge are willing to share the actual workflow. As of now, we cannot commit to providing a solution. Hopefully, you can close this issue but no worries, I will be working on the M600 issue and also the relative movement issue which will potential solve this issue of yours.

mjmurray68 commented 4 years ago

Not a Bug - Closing pending future DWIN DGUS Workflow.

thinkyhead commented 4 years ago

The only tools available for converting / editing the ICO files (and others) are for Windows. I don't have a working Windows VM or WINE layer right now so I haven't tried them. For the menu strings in the JPG file I did some small tweaks to both the graphics and to the code to align them a bit better. Any changes to the language JPG files will need to be accompanied by changes to the dwin.cpp file which draws them.

I've simplified the menu item drawing a lot in dwin.cpp compared to the original code from Creality, which had a lot of repetition in it. The cleanest way to manage new string pictures is to follow the same pattern that I've established there.

All that said, my intention is to implement all the MarlinUI methods for the Ender 3 V2 screen so it can display the entire Marlin menu tree complete with select screens, edit screens, etc. In support of that effort I need to figure out whether the screen can display real fonts complete with accents so that it can display all of Marlin's languages, including Chinese — and then we don't have to put any menu titles into JPG files.

fleek commented 4 years ago

@thinkyhead This is what I can pull from DWIN's website, seems that it can display fonts directly through the serial interface, but there is no option to select fonts. T5UIC1 Kernel Application Guide.pdf

If I read this documentation. I believe to update the files on the smart screen, you need to take the screen out of the housing and there should be a SD card slot on the screen itself. Not sure if the current firmware bootloader does read the DWIN_SET to update the smart screen, but I believe it probably does not.

I have taken my screen apart and there is a SD card slot. IMG_20200730_142121 IMG_20200730_142229

迪文ICO V3.6.zip

This is the icon editor that I have found, you can open the .ICO file but you cannot edit it, you need to place all original files in a directory and let the software compile them into a .ICO file.

JPGConvert V1.2.zip

This is the jpg converter, converting the images to 4:4:4 format and saving the files with the correct naming convention.

DW_0Font.zip

This is the font .HZK file generator, as far as I can see from the app, the character codes 0-255 will be mapped to the characters in the .HZK file, if we can fit all the required special characters for the various languages to within this 255 characters, we can support direct printing from the serial interface, otherwise we have to rely on the pre-designed messages in the JPG files.

mjmurray68 commented 4 years ago

@fleek - as part of my workflow, I had cracked open my display as well, and flashed with the DWIn_Set from Configurations, as per the README in the DWIN_Set Directory. I raised the issue when I saw the changes made by @thinkyhead referenced above didn't come across. Or more accurately, the changes to the dwin.cpp took, but not the changes to the image file). My end goal wasn't to correct the grammar of "Store Configurations" but rather to better understand if changes could be made to the UI, perchance to be able to leverage Manual Mesh Bed Leveling. I'm happy to wait.

fleek commented 4 years ago

@mjmurray68 Sorry for hijacking your thread, but my intention is to share my investigations with Scott (thinkyhead), hoping I can help in anyway to advance the development of the MarlinUI. Today, the smart display is actually a hindrance to incorporating certain functionalities of Marlin such as filament sensor (M600) which I needed and also some form of custom user menu which was available in my previous Anet A8.

cosmoderp commented 4 years ago

edit .... nevermind. I just realized its the flashing of the screen image that does not work since it still said storage configuration. I am going to bed LOL

cosmoderp commented 4 years ago

sorry for hijacking as well but there is nowhere else where people have info on this....@fleek since you seem to have found the proper version of DWIN icon file generator what version of DGUS tools did this come from. there has to be one with a more up to date version. best t5 one I found only had icon app v2?

cosmoderp commented 4 years ago

I solved this and will also post here for people that have trouble in the future. 1 the creality provided SD card does not work 2 make the card you choose is formatted fat32 AND also your allocation size is 4k 3 you should see blue screen followed by orange I could not get it to work and when you format it fat 32 and its not 4k it will act like its flashing blue then orange but in reality its failing every time once I set the 4k allocation size bingo

you only need the single file you want to update so if you just want to update store config only add 1_English.JPG to the DWIN_SET folder and nothing else.

github-actions[bot] commented 4 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.