search

MarlinFirmware / Marlin

Marlin is an optimized firmware for RepRap 3D printers based on the Arduino platform. Many commercial 3D printers come with Marlin installed. Check with your vendor if you need source code for your specific machine.
https://marlinfw.org
GNU General Public License v3.0
16.11k stars 19.2k forks source link

[BUG] compile failure in LCD DAC edit menu (board w/MCP4728 DAC) #19216

Closed fiveangle closed 3 years ago

fiveangle commented 3 years ago

Printrboard RevF (AT90USB) compile failure:

In file included from Marlin/src/lcd/menu/menu_advanced.cpp:31:0:
Marlin/src/lcd/menu/menu_advanced.cpp: In function 'void menu_dac()':
Marlin/src/lcd/menu/../../inc/../core/language.h:319:15: error: expected unqualified-id before string constant
 #define MSG_X "X"
               ^
Marlin/src/lcd/menu/menu.h:348:26: note: in definition of macro '_MENU_ITEM_P'
     PGM_P const plabel = PLABEL;                                \
                          ^
Marlin/src/lcd/menu/menu.h:380:48: note: in expansion of macro 'MENU_ITEM_P'
 #define EDIT_ITEM_P(TYPE, PLABEL, V...)        MENU_ITEM_P(TYPE, PLABEL, ##V)
                                                ^
Marlin/src/lcd/menu/menu.h:381:48: note: in expansion of macro 'EDIT_ITEM_P'
 #define EDIT_ITEM(TYPE, LABEL, V...)           EDIT_ITEM_P(TYPE, GET_TEXT(LABEL), ##V)
                                                ^
Marlin/src/lcd/menu/menu.h:381:66: note: in expansion of macro 'GET_TEXT'
 #define EDIT_ITEM(TYPE, LABEL, V...)           EDIT_ITEM_P(TYPE, GET_TEXT(LABEL), ##V)
                                                                  ^
Marlin/src/lcd/menu/menu_advanced.cpp:68:33: note: in expansion of macro 'EDIT_ITEM'
     #define EDIT_DAC_PERCENT(A) EDIT_ITEM(uint8, MSG_##A " " MSG_DAC_PERCENT, &driverPercent[_AXIS(A)], 0, 100, []{ dac_current_set_percents(driverPercent); })
                                 ^
Marlin/src/lcd/menu/menu_advanced.cpp:68:50: note: in expansion of macro 'MSG_X'
     #define EDIT_DAC_PERCENT(A) EDIT_ITEM(uint8, MSG_##A " " MSG_DAC_PERCENT, &driverPercent[_AXIS(A)], 0, 100, []{ dac_current_set_percents(driverPercent); })
                                                  ^
Marlin/src/lcd/menu/menu_advanced.cpp:69:5: note: in expansion of macro 'EDIT_DAC_PERCENT'
     EDIT_DAC_PERCENT(X);
     ^
Marlin/src/lcd/menu/../../inc/../core/language.h:320:15: error: expected unqualified-id before string constant
 #define MSG_Y "Y"
               ^
Marlin/src/lcd/menu/menu.h:348:26: note: in definition of macro '_MENU_ITEM_P'
     PGM_P const plabel = PLABEL;                                \
                          ^
Marlin/src/lcd/menu/menu.h:380:48: note: in expansion of macro 'MENU_ITEM_P'
 #define EDIT_ITEM_P(TYPE, PLABEL, V...)        MENU_ITEM_P(TYPE, PLABEL, ##V)
                                                ^
Marlin/src/lcd/menu/menu.h:381:48: note: in expansion of macro 'EDIT_ITEM_P'
 #define EDIT_ITEM(TYPE, LABEL, V...)           EDIT_ITEM_P(TYPE, GET_TEXT(LABEL), ##V)
                                                ^
Marlin/src/lcd/menu/menu.h:381:66: note: in expansion of macro 'GET_TEXT'
 #define EDIT_ITEM(TYPE, LABEL, V...)           EDIT_ITEM_P(TYPE, GET_TEXT(LABEL), ##V)
                                                                  ^
Marlin/src/lcd/menu/menu_advanced.cpp:68:33: note: in expansion of macro 'EDIT_ITEM'
     #define EDIT_DAC_PERCENT(A) EDIT_ITEM(uint8, MSG_##A " " MSG_DAC_PERCENT, &driverPercent[_AXIS(A)], 0, 100, []{ dac_current_set_percents(driverPercent); })
                                 ^
Marlin/src/lcd/menu/menu_advanced.cpp:68:50: note: in expansion of macro 'MSG_Y'
     #define EDIT_DAC_PERCENT(A) EDIT_ITEM(uint8, MSG_##A " " MSG_DAC_PERCENT, &driverPercent[_AXIS(A)], 0, 100, []{ dac_current_set_percents(driverPercent); })
                                                  ^
Marlin/src/lcd/menu/menu_advanced.cpp:70:5: note: in expansion of macro 'EDIT_DAC_PERCENT'
     EDIT_DAC_PERCENT(Y);
     ^
Marlin/src/lcd/menu/../../inc/../core/language.h:321:15: error: expected unqualified-id before string constant
 #define MSG_Z "Z"
               ^
Marlin/src/lcd/menu/menu.h:348:26: note: in definition of macro '_MENU_ITEM_P'
     PGM_P const plabel = PLABEL;                                \
                          ^
Marlin/src/lcd/menu/menu.h:380:48: note: in expansion of macro 'MENU_ITEM_P'
 #define EDIT_ITEM_P(TYPE, PLABEL, V...)        MENU_ITEM_P(TYPE, PLABEL, ##V)
                                                ^
Marlin/src/lcd/menu/menu.h:381:48: note: in expansion of macro 'EDIT_ITEM_P'
 #define EDIT_ITEM(TYPE, LABEL, V...)           EDIT_ITEM_P(TYPE, GET_TEXT(LABEL), ##V)
                                                ^
Marlin/src/lcd/menu/menu.h:381:66: note: in expansion of macro 'GET_TEXT'
 #define EDIT_ITEM(TYPE, LABEL, V...)           EDIT_ITEM_P(TYPE, GET_TEXT(LABEL), ##V)
                                                                  ^
Marlin/src/lcd/menu/menu_advanced.cpp:68:33: note: in expansion of macro 'EDIT_ITEM'
     #define EDIT_DAC_PERCENT(A) EDIT_ITEM(uint8, MSG_##A " " MSG_DAC_PERCENT, &driverPercent[_AXIS(A)], 0, 100, []{ dac_current_set_percents(driverPercent); })
                                 ^
Marlin/src/lcd/menu/menu_advanced.cpp:68:50: note: in expansion of macro 'MSG_Z'
     #define EDIT_DAC_PERCENT(A) EDIT_ITEM(uint8, MSG_##A " " MSG_DAC_PERCENT, &driverPercent[_AXIS(A)], 0, 100, []{ dac_current_set_percents(driverPercent); })
                                                  ^
Marlin/src/lcd/menu/menu_advanced.cpp:71:5: note: in expansion of macro 'EDIT_DAC_PERCENT'
     EDIT_DAC_PERCENT(Z);
     ^
Marlin/src/lcd/menu/../../inc/../core/language.h:322:15: error: expected unqualified-id before string constant
 #define MSG_E "E"
               ^
Marlin/src/lcd/menu/menu.h:348:26: note: in definition of macro '_MENU_ITEM_P'
     PGM_P const plabel = PLABEL;                                \
                          ^
Marlin/src/lcd/menu/menu.h:380:48: note: in expansion of macro 'MENU_ITEM_P'
 #define EDIT_ITEM_P(TYPE, PLABEL, V...)        MENU_ITEM_P(TYPE, PLABEL, ##V)
                                                ^
Marlin/src/lcd/menu/menu.h:381:48: note: in expansion of macro 'EDIT_ITEM_P'
 #define EDIT_ITEM(TYPE, LABEL, V...)           EDIT_ITEM_P(TYPE, GET_TEXT(LABEL), ##V)
                                                ^
Marlin/src/lcd/menu/menu.h:381:66: note: in expansion of macro 'GET_TEXT'
 #define EDIT_ITEM(TYPE, LABEL, V...)           EDIT_ITEM_P(TYPE, GET_TEXT(LABEL), ##V)
                                                                  ^
Marlin/src/lcd/menu/menu_advanced.cpp:68:33: note: in expansion of macro 'EDIT_ITEM'
     #define EDIT_DAC_PERCENT(A) EDIT_ITEM(uint8, MSG_##A " " MSG_DAC_PERCENT, &driverPercent[_AXIS(A)], 0, 100, []{ dac_current_set_percents(driverPercent); })
                                 ^
Marlin/src/lcd/menu/menu_advanced.cpp:68:50: note: in expansion of macro 'MSG_E'
     #define EDIT_DAC_PERCENT(A) EDIT_ITEM(uint8, MSG_##A " " MSG_DAC_PERCENT, &driverPercent[_AXIS(A)], 0, 100, []{ dac_current_set_percents(driverPercent); })
                                                  ^
Marlin/src/lcd/menu/menu_advanced.cpp:72:5: note: in expansion of macro 'EDIT_DAC_PERCENT'
     EDIT_DAC_PERCENT(E);
     ^
*** [.pio/build/at90usb1286_dfu/src/src/lcd/menu/menu_advanced.cpp.o] Error 1
========================= [FAILED] Took 13.46 seconds =========================

My Configurations

https://github.com/fiveangle/Marlin/tree/bf2-2020-08-31/Marlin https://github.com/fiveangle/Marlin/blob/bf2-2020-08-31/Marlin/Configuration.h https://github.com/fiveangle/Marlin/blob/bf2-2020-08-31/Marlin/Configuration_adv.h

ellensp commented 3 years ago

Configs are version 2.0 we are currently at 2.0.6.1 please use a current Marlin

fiveangle commented 3 years ago

Configs are version 2.0 we are currently at 2.0.6.1 please use a current Marlin

Thanks for the oversight of a second set of eyes. Blew caches away from IDE and refreshed d/l's from scratch and indeed there was an issue with my IDE.

Current compile failure appears as it may be related to same issue as previous cached version with different manifestation:

[avr-g++ -o .pio/build/at90usb1286_dfu/firmware.elf -fmerge-all-constants -Os -Wl,--gc-sections,--relax -mmcu=at90usb1286 .pio/build/at90usb1286_dfu/src/src/HAL/AVR/HAL.cpp.o .pio/build/at90usb1286_dfu/src/src/HAL/AVR/HAL_SPI.cpp.o .pio/build/at90usb1286_dfu/src/src/HAL/AVR/MarlinSerial.cpp.o .pio/build/at90usb1286_dfu/src/src/HAL/AVR/Servo.cpp.o .pio/build/at90usb1286_dfu/src/src/HAL/AVR/eeprom.cpp.o .pio/build/at90usb1286_dfu/src/src/HAL/AVR/fast_pwm.cpp.o .pio/build/at90usb1286_dfu/src/src/HAL/AVR/fastio.cpp.o .pio/build/at90usb1286_dfu/src/src/HAL/AVR/u8g_com_HAL_AVR_sw_spi.cpp.o .pio/build/at90usb1286_dfu/src/src/HAL/AVR/watchdog.cpp.o .pio/build/at90usb1286_dfu/src/src/HAL/shared/HAL_spi_L6470.cpp.o .pio/build/at90usb1286_dfu/src/src/HAL/shared/backtrace/backtrace.cpp.o .pio/build/at90usb1286_dfu/src/src/HAL/shared/backtrace/unwarm.cpp.o .pio/build/at90usb1286_dfu/src/src/HAL/shared/backtrace/unwarm_arm.cpp.o .pio/build/at90usb1286_dfu/src/src/HAL/shared/backtrace/unwarm_thumb.cpp.o .pio/build/at90usb1286_dfu/src/src/HAL/shared/backtrace/unwarmbytab.cpp.o .pio/build/at90usb1286_dfu/src/src/HAL/shared/backtrace/unwarmmem.cpp.o .pio/build/at90usb1286_dfu/src/src/HAL/shared/backtrace/unwinder.cpp.o .pio/build/at90usb1286_dfu/src/src/HAL/shared/backtrace/unwmemaccess.cpp.o .pio/build/at90usb1286_dfu/src/src/HAL/shared/eeprom_api.cpp.o .pio/build/at90usb1286_dfu/src/src/HAL/shared/eeprom_if_i2c.cpp.o .pio/build/at90usb1286_dfu/src/src/HAL/shared/eeprom_if_spi.cpp.o .pio/build/at90usb1286_dfu/src/src/HAL/shared/esp_wifi.cpp.o .pio/build/at90usb1286_dfu/src/src/HAL/shared/servo.cpp.o .pio/build/at90usb1286_dfu/src/src/MarlinCore.cpp.o .pio/build/at90usb1286_dfu/src/src/core/serial.cpp.o .pio/build/at90usb1286_dfu/src/src/core/utility.cpp.o .pio/build/at90usb1286_dfu/src/src/feature/babystep.cpp.o .pio/build/at90usb1286_dfu/src/src/feature/bedlevel/bedlevel.cpp.o .pio/build/at90usb1286_dfu/src/src/feature/bedlevel/mbl/mesh_bed_leveling.cpp.o .pio/build/at90usb1286_dfu/src/src/feature/caselight.cpp.o .pio/build/at90usb1286_dfu/src/src/feature/leds/neopixel.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/bedlevel/G42.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/bedlevel/M420.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/bedlevel/mbl/G29.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/bedlevel/mbl/M421.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/calibrate/G28.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/config/M200-M205.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/config/M220.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/config/M221.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/config/M301.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/config/M304.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/config/M575.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/config/M672.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/config/M92.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/control/M108_M112_M410.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/control/M111.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/control/M120_M121.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/control/M17_M18_M84.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/control/M211.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/control/M226.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/control/M280.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/control/M350_M351.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/control/M380_M381.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/control/M400.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/control/M42.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/control/M80_M81.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/control/M85.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/control/M993_M994.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/control/M997.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/control/M999.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/control/T.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/eeprom/M500-M504.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/feature/advance/M900.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/feature/digipot/M907-M910.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/feature/pause/G27.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/gcode.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/geometry/G92.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/host/M110.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/host/M113.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/host/M114.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/host/M115.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/host/M118.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/host/M119.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/lcd/M0_M1.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/lcd/M117.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/lcd/M145.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/lcd/M250.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/lcd/M300.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/motion/G0_G1.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/motion/G4.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/parser.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/queue.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/stats/M31.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/stats/M75-M78.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/temp/M104_M109.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/temp/M105.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/temp/M106_M107.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/temp/M140_M190.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/temp/M141_M191.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/temp/M155.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/temp/M303.cpp.o .pio/build/at90usb1286_dfu/src/src/gcode/units/M82_M83.cpp.o .pio/build/at90usb1286_dfu/src/src/lcd/dogm/lcdprint_u8g.cpp.o .pio/build/at90usb1286_dfu/src/src/lcd/dogm/status_screen_DOGM.cpp.o .pio/build/at90usb1286_dfu/src/src/lcd/dogm/status_screen_lite_ST7920.cpp.o .pio/build/at90usb1286_dfu/src/src/lcd/dogm/u8g_dev_ssd1306_sh1106_128x64_I2C.cpp.o .pio/build/at90usb1286_dfu/src/src/lcd/dogm/u8g_dev_st7565_64128n_HAL.cpp.o .pio/build/at90usb1286_dfu/src/src/lcd/dogm/u8g_dev_st7920_128x64_HAL.cpp.o .pio/build/at90usb1286_dfu/src/src/lcd/dogm/u8g_dev_tft_320x240_upscale_from_128x64.cpp.o .pio/build/at90usb1286_dfu/src/src/lcd/dogm/u8g_dev_uc1701_mini12864_HAL.cpp.o .pio/build/at90usb1286_dfu/src/src/lcd/dogm/u8g_fontutf8.cpp.o .pio/build/at90usb1286_dfu/src/src/lcd/dogm/ultralcd_DOGM.cpp.o .pio/build/at90usb1286_dfu/src/src/lcd/dogm/ultralcd_st7920_u8glib_rrd_AVR.cpp.o .pio/build/at90usb1286_dfu/src/src/lcd/extui/anycubic_chiron_lcd.cpp.o .pio/build/at90usb1286_dfu/src/src/lcd/extui/anycubic_i3mega_lcd.cpp.o .pio/build/at90usb1286_dfu/src/src/lcd/extui/ui_api.cpp.o .pio/build/at90usb1286_dfu/src/src/lcd/fontutils.cpp.o .pio/build/at90usb1286_dfu/src/src/lcd/lcdprint.cpp.o .pio/build/at90usb1286_dfu/src/src/lcd/menu/menu.cpp.o .pio/build/at90usb1286_dfu/src/src/lcd/menu/menu_advanced.cpp.o .pio/build/at90usb1286_dfu/src/src/lcd/menu/menu_configuration.cpp.o .pio/build/at90usb1286_dfu/src/src/lcd/menu/menu_custom.cpp.o .pio/build/at90usb1286_dfu/src/src/lcd/menu/menu_game.cpp.o .pio/build/at90usb1286_dfu/src/src/lcd/menu/menu_main.cpp.o .pio/build/at90usb1286_dfu/src/src/lcd/menu/menu_mixer.cpp.o .pio/build/at90usb1286_dfu/src/src/lcd/menu/menu_motion.cpp.o .pio/build/at90usb1286_dfu/src/src/lcd/menu/menu_temperature.cpp.o .pio/build/at90usb1286_dfu/src/src/lcd/menu/menu_tune.cpp.o .pio/build/at90usb1286_dfu/src/src/lcd/touch/touch_buttons.cpp.o .pio/build/at90usb1286_dfu/src/src/lcd/ultralcd.cpp.o .pio/build/at90usb1286_dfu/src/src/libs/BL24CXX.cpp.o .pio/build/at90usb1286_dfu/src/src/libs/W25Qxx.cpp.o .pio/build/at90usb1286_dfu/src/src/libs/buzzer.cpp.o .pio/build/at90usb1286_dfu/src/src/libs/crc16.cpp.o .pio/build/at90usb1286_dfu/src/src/libs/nozzle.cpp.o .pio/build/at90usb1286_dfu/src/src/libs/numtostr.cpp.o .pio/build/at90usb1286_dfu/src/src/libs/stopwatch.cpp.o .pio/build/at90usb1286_dfu/src/src/libs/vector_3.cpp.o .pio/build/at90usb1286_dfu/src/src/module/endstops.cpp.o .pio/build/at90usb1286_dfu/src/src/module/motion.cpp.o .pio/build/at90usb1286_dfu/src/src/module/planner.cpp.o .pio/build/at90usb1286_dfu/src/src/module/servo.cpp.o .pio/build/at90usb1286_dfu/src/src/module/settings.cpp.o .pio/build/at90usb1286_dfu/src/src/module/stepper.cpp.o .pio/build/at90usb1286_dfu/src/src/module/stepper/indirection.cpp.o .pio/build/at90usb1286_dfu/src/src/module/temperature.cpp.o .pio/build/at90usb1286_dfu/src/src/module/tool_change.cpp.o .pio/build/at90usb1286_dfu/src/src/sd/Sd2Card.cpp.o .pio/build/at90usb1286_dfu/src/src/sd/SdBaseFile.cpp.o .pio/build/at90usb1286_dfu/src/src/sd/SdFatUtil.cpp.o .pio/build/at90usb1286_dfu/src/src/sd/SdFile.cpp.o .pio/build/at90usb1286_dfu/src/src/sd/SdVolume.cpp.o .pio/build/at90usb1286_dfu/src/src/sd/cardreader.cpp.o -L.pio/build/at90usb1286_dfu -Wl,--start-group .pio/build/at90usb1286_dfu/lib244/libSPI.a .pio/build/at90usb1286_dfu/lib149/libWire.a .pio/build/at90usb1286_dfu/libed2/libU8glib-HAL_ID1932.a .pio/build/at90usb1286_dfu/lib63c/libSailfishLCD@src-75ea08fd0b73622d5d2bd72b00fa5eda.a .pio/build/at90usb1286_dfu/libfbe/libServo.a .pio/build/at90usb1286_dfu/lib837/libSoftwareSerial.a .pio/build/at90usb1286_dfu/libbcb/libSlowSoftI2CMaster@src-2efb75bffbdabc45f736f5ee24590d52.a .pio/build/at90usb1286_dfu/lib203/libEEPROM.a .pio/build/at90usb1286_dfu/lib708/libLiquidTWI2@src-9f6a183b4f3ef33e94fcf23bb604c074.a .pio/build/at90usb1286_dfu/lib819/libTMC26XStepper@src-d7635cbe3386c6c3bf6c9ab5b4141aa8.a .pio/build/at90usb1286_dfu/libFrameworkArduino.a -lm -Wl,--end-group
.pio/build/at90usb1286_dfu/src/src/MarlinCore.cpp.o: In function `setup':
MarlinCore.cpp:(.text.setup+0x130): undefined reference to `dac_init()'
.pio/build/at90usb1286_dfu/src/src/gcode/feature/digipot/M907-M910.cpp.o: In function `GcodeSuite::M907()':
/home/speedster/dev/git/Marlin/Marlin/src/gcode/feature/digipot/M907-M910.cpp:77: undefined reference to `dac_current_percent(unsigned char, float)'
/home/speedster/dev/git/Marlin/Marlin/src/gcode/feature/digipot/M907-M910.cpp:79: undefined reference to `dac_current_percent(unsigned char, float)'
.pio/build/at90usb1286_dfu/src/src/gcode/feature/digipot/M907-M910.cpp.o: In function `GcodeSuite::M908()':
/home/speedster/dev/git/Marlin/Marlin/src/gcode/feature/digipot/M907-M910.cpp:90: undefined reference to `dac_current_raw(unsigned char, unsigned int)'
.pio/build/at90usb1286_dfu/src/src/gcode/feature/digipot/M907-M910.cpp.o: In function `GcodeSuite::M909()':
/home/speedster/dev/git/Marlin/Marlin/src/gcode/feature/digipot/M907-M910.cpp:97: undefined reference to `dac_print_values()'
.pio/build/at90usb1286_dfu/src/src/gcode/feature/digipot/M907-M910.cpp.o: In function `GcodeSuite::M910()':
/home/speedster/dev/git/Marlin/Marlin/src/gcode/feature/digipot/M907-M910.cpp:98: undefined reference to `dac_commit_eeprom()'
.pio/build/at90usb1286_dfu/src/src/lcd/menu/menu_advanced.cpp.o: In function `menu_dac()::{lambda()#3}::_FUN()':
menu_advanced.cpp:(.text._ZZ8menu_dacvENUlvE1_4_FUNEv+0x4): undefined reference to `dac_current_set_percents(XYZEval<unsigned char>&)'
.pio/build/at90usb1286_dfu/src/src/lcd/menu/menu_advanced.cpp.o: In function `menu_dac()::{lambda()#1}::_FUN()':
menu_advanced.cpp:(.text._ZZ8menu_dacvENUlvE_4_FUNEv+0x4): undefined reference to `dac_current_set_percents(XYZEval<unsigned char>&)'
.pio/build/at90usb1286_dfu/src/src/lcd/menu/menu_advanced.cpp.o: In function `menu_dac()::{lambda()#5}::_FUN()':
menu_advanced.cpp:(.text._ZZ8menu_dacvENUlvE3_4_FUNEv+0x4): undefined reference to `dac_current_set_percents(XYZEval<unsigned char>&)'
.pio/build/at90usb1286_dfu/src/src/lcd/menu/menu_advanced.cpp.o: In function `menu_dac()::{lambda()#7}::_FUN()':
menu_advanced.cpp:(.text._ZZ8menu_dacvENUlvE5_4_FUNEv+0x4): undefined reference to `dac_current_set_percents(XYZEval<unsigned char>&)'
.pio/build/at90usb1286_dfu/src/src/lcd/menu/menu_advanced.cpp.o: In function `menu_dac()':
menu_advanced.cpp:(.text._Z8menu_dacv+0x12): undefined reference to `dac_current_get_percent(AxisEnum)'
menu_advanced.cpp:(.text._Z8menu_dacv+0x226): undefined reference to `dac_commit_eeprom()'
collect2: error: ld returned 1 exit status
*** [.pio/build/at90usb1286_dfu/firmware.elf] Error 1
========================== [FAILED] Took 3.93 seconds ==========================]

Current configs pushed to above repo.

ellensp commented 3 years ago

try adding #define DAC_STEPPER_CURRENT to your configuration.h

github-actions[bot] commented 3 years ago

This issue has had no activity in the last 30 days. Please add a reply if you want to keep this issue active, otherwise it will be automatically closed within 7 days.

fiveangle commented 3 years ago

try adding #define DAC_STEPPER_CURRENT to your configuration.h

This is a red herring. DAC_STEPPER_CURRENT has always been set it the pins file for the Printrboard RevF and still is:

https://github.com/MarlinFirmware/Marlin/blob/348570fd683b56ebb930da9405aaf282c1165c0a/Marlin/src/pins/teensy2/pins_PRINTRBOARD_REVF.h#L145-L146

Currently as of https://github.com/MarlinFirmware/Marlin/commit/348570fd683b56ebb930da9405aaf282c1165c0a it's gone from the frying pan and into the fire with what looks like a problem with the Teensy2 library, as USBCON is typically set there:

Processing at90usb1286_dfu (platform: teensy; extends: env:at90usb1286_cdc; board: at90usb1286; board_build.f_cpu: 16000000L; src_filter: +<src/*> -<src/config> -<src/HAL> +<src/HAL/shared>, -<src/lcd/HD44780> -<src/lcd/TFTGLCD> -<src/lcd/dwin> -<src/lcd/dogm> -<src/lcd/tft>, -<src/lcd/menu>, -<src/lcd/menu/game/game.cpp> -<src/lcd/menu/game/brickout.cpp> -<src/lcd/menu/game/invaders.cpp>, -<src/lcd/menu/game/maze.cpp> -<src/lcd/menu/game/snake.cpp>, -<src/lcd/menu/menu_backlash.cpp>, -<src/lcd/menu/menu_bed_corners.cpp>, -<src/lcd/menu/menu_bed_leveling.cpp>, -<src/lcd/menu/menu_cancelobject.cpp>, -<src/lcd/menu/menu_delta_calibrate.cpp>, -<src/lcd/menu/menu_filament.cpp>, -<src/lcd/menu/menu_info.cpp>, -<src/lcd/menu/menu_job_recovery.cpp>, -<src/lcd/menu/menu_led.cpp>, -<src/lcd/menu/menu_media.cpp>, -<src/lcd/menu/menu_mmu2.cpp>, -<src/lcd/menu/menu_password.cpp>, -<src/lcd/menu/menu_power_monitor.cpp>, -<src/lcd/menu/menu_spindle_laser.cpp>, -<src/lcd/menu/menu_temperature.cpp>, -<src/lcd/menu/menu_tmc.cpp>, -<src/lcd/menu/menu_touch_screen.cpp>, -<src/lcd/menu/menu_ubl.cpp>, -<src/lcd/extui/lib/mks_ui>, -<src/lcd/extui/lib/dgus> -<src/lcd/extui/dgus_lcd.cpp>, -<src/lcd/extui/example.cpp>, -<src/lcd/extui/malyan_lcd.cpp>, -<src/lcd/extui/lib/ftdi_eve_touch_ui>, -<src/lcd/extui/anycubic_chiron_lcd.cpp>, -<src/lcd/extui/anycubic_i3mega_lcd.cpp> -<src/lcd/extui/lib/anycubic_i3mega>, -<src/lcd/lcdprint.cpp>, -<src/sd/usb_flashdrive>, -<src/feature/backlash.cpp>, -<src/feature/baricuda.cpp> -<src/gcode/feature/baricuda>, -<src/feature/bedlevel/abl> -<src/gcode/bedlevel/abl>, -<src/feature/bedlevel/mbl> -<src/gcode/bedlevel/mbl>, -<src/feature/bedlevel/ubl> -<src/gcode/bedlevel/ubl>, -<src/feature/binary_stream.cpp> -<src/libs/heatshrink>, -<src/feature/bltouch.cpp>, -<src/feature/cancel_object.cpp> -<src/gcode/feature/cancel>, -<src/feature/caselight> -<src/gcode/feature/caselight>, -<src/feature/closedloop.cpp>, -<src/feature/controllerfan.cpp> -<src/gcode/feature/controllerfan>, -<src/feature/dac> -<src/feature/digipot>, -<src/feature/direct_stepping.cpp> -<src/gcode/motion/G6.cpp>, -<src/feature/e_parser.cpp>, -<src/feature/encoder_i2c.cpp>, -<src/feature/fanmux.cpp>, -<src/feature/filwidth.cpp> -<src/gcode/feature/filwidth>, -<src/feature/fwretract.cpp> -<src/gcode/feature/fwretract>, -<src/feature/host_actions.cpp>, -<src/feature/hotend_idle.cpp>, -<src/feature/joystick.cpp>, -<src/feature/leds/blinkm.cpp>, -<src/feature/leds/leds.cpp>, -<src/feature/leds/pca9533.cpp>, -<src/feature/leds/pca9632.cpp>, -<src/feature/leds/printer_event_leds.cpp>, -<src/feature/leds/tempstat.cpp>, -<src/feature/max7219.cpp>, -<src/feature/mixing.cpp>, -<src/feature/mmu2> -<src/gcode/feature/prusa_MMU2>, -<src/feature/password> -<src/gcode/feature/password>, -<src/feature/pause.cpp>, -<src/feature/power.cpp>, -<src/feature/power_monitor.cpp> -<src/gcode/feature/power_monitor>, -<src/feature/powerloss.cpp> -<src/gcode/feature/powerloss>, -<src/feature/probe_temp_comp.cpp>, -<src/feature/runout.cpp> -<src/gcode/feature/runout>, -<src/feature/snmm.cpp>, -<src/feature/solenoid.cpp>, -<src/feature/spindle_laser.cpp> -<src/gcode/control/M3-M5.cpp>, -<src/feature/tmc_util.cpp> -<src/module/stepper/trinamic.cpp>, -<src/feature/twibus.cpp>, -<src/feature/z_stepper_align.cpp>, -<src/gcode/bedlevel/G26.cpp>, -<src/gcode/bedlevel/G35.cpp>, -<src/gcode/bedlevel/G42.cpp>, -<src/gcode/bedlevel/M420.cpp>, -<src/gcode/calibrate/G33.cpp>, -<src/gcode/calibrate/G34_M422.cpp>, -<src/gcode/calibrate/G76_M871.cpp>, -<src/gcode/calibrate/G425.cpp>, -<src/gcode/calibrate/M12.cpp>, -<src/gcode/calibrate/M48.cpp>, -<src/gcode/calibrate/M100.cpp>, -<src/gcode/calibrate/M425.cpp>, -<src/gcode/calibrate/M666.cpp>, -<src/gcode/calibrate/M852.cpp>, -<src/gcode/config/M43.cpp>, -<src/gcode/config/M217.cpp>, -<src/gcode/config/M218.cpp>, -<src/gcode/config/M221.cpp>, -<src/gcode/config/M281.cpp>, -<src/gcode/config/M302.cpp>, -<src/gcode/config/M305.cpp>, -<src/gcode/config/M540.cpp>, -<src/gcode/control/M7-M9.cpp>, -<src/gcode/control/M211.cpp>, -<src/gcode/control/M605.cpp>, -<src/gcode/feature/advance>, -<src/gcode/feature/camera>, -<src/gcode/feature/i2c>, -<src/gcode/feature/L6470>, -<src/gcode/feature/leds/M150.cpp>, -<src/gcode/feature/leds/M7219.cpp>, -<src/gcode/feature/macro>, -<src/gcode/feature/mixing/M163-M165.cpp>, -<src/gcode/feature/mixing/M166.cpp>, -<src/gcode/feature/pause/G27.cpp>, -<src/gcode/feature/pause/G60.cpp>, -<src/gcode/feature/pause/G61.cpp>, -<src/gcode/feature/pause/M125.cpp>, -<src/gcode/feature/pause/M600.cpp>, -<src/gcode/feature/pause/M603.cpp>, -<src/gcode/feature/pause/M701_M702.cpp>, -<src/gcode/feature/trinamic/M122.cpp>, -<src/gcode/feature/trinamic/M569.cpp>, -<src/gcode/feature/trinamic/M906.cpp>, -<src/gcode/feature/trinamic/M911-M914.cpp>, -<src/gcode/geometry/G17-G19.cpp>, -<src/gcode/geometry/G53-G59.cpp>, -<src/gcode/geometry/M206_M428.cpp>, -<src/gcode/host/M16.cpp>, -<src/gcode/host/M113.cpp>, -<src/gcode/host/M360.cpp>, -<src/gcode/host/M876.cpp>, -<src/gcode/lcd/M0_M1.cpp>, -<src/gcode/lcd/M250.cpp>, -<src/gcode/lcd/M73.cpp>, -<src/gcode/lcd/M995.cpp>, -<src/gcode/motion/G2_G3.cpp>, -<src/gcode/motion/G5.cpp>, -<src/gcode/motion/G80.cpp>, -<src/gcode/motion/M290.cpp>, -<src/gcode/probe/G30.cpp>, -<src/gcode/probe/G31_G32.cpp>, -<src/gcode/probe/G38.cpp>, -<src/gcode/probe/M401_M402.cpp>, -<src/gcode/probe/M851.cpp>, -<src/gcode/probe/M951.cpp>, -<src/gcode/scara>, -<src/gcode/sd>, -<src/gcode/temp/M104_M109.cpp>, -<src/gcode/units/G20_G21.cpp>, -<src/gcode/units/M149.cpp>, -<src/libs/L64XX> -<src/module/stepper/L64xx.cpp>, -<src/libs/hex_print.cpp>, -<src/libs/least_squares_fit.cpp>, -<src/libs/nozzle.cpp> -<src/gcode/feature/clean>, -<src/module/delta.cpp>, -<src/module/planner_bezier.cpp>, -<src/module/printcounter.cpp>, -<src/module/probe.cpp>, -<src/module/scara.cpp> -<src/gcode/calibrate/M665.cpp>, -<src/module/stepper/TMC26X.cpp> +<src/HAL/AVR>; framework: arduino; extra_scripts: pre:buildroot/share/PlatformIO/scripts/common-dependencies.py, pre:buildroot/share/PlatformIO/scripts/common-cxxflags.py, post:buildroot/share/PlatformIO/scripts/common-dependencies-post.py; build_flags: -fmax-errors=5 -g -D__MARLIN_FIRMWARE__ -fmerge-all-constants; lib_deps: ; monitor_speed: 250000; monitor_flags: --quiet, --echo, --eol, LF, --filter, colorize, --filter, time)
-------------------------------------------------------------------------------
In file included from c:\dev\git\marlin\marlin\src\pins\pins.h:353:0,

                 from buildroot/share/PlatformIO/scripts/common-dependencies.h:150:

c:\dev\git\marlin\marlin\src\pins\teensy2/pins_PRINTRBOARD_REVF.h:71:4: error: #error "USBCON should be defined by the platform for this board."

   #error "USBCON should be defined by the platform for this board."

    ^

CalledProcessError: Command 'avr-g++.exe -D__MARLIN_FIRMWARE__ -D__MARLIN_PREBUILD__ -w -dM -E -x c++ buildroot/share/PlatformIO/scripts/common-dependencies.h' returned non-zero exit status 1:

  File "C:\python27\lib\site-packages\platformio\builder\main.py", line 167:

    env.SConscript(item, exports="env")

  File "C:\Users\speedster\.platformio\packages\tool-scons\script\..\engine\SCons\Script\SConscript.py", line 541:

    return _SConscript(self.fs, *files, **subst_kw)

  File "C:\Users\speedster\.platformio\packages\tool-scons\script\..\engine\SCons\Script\SConscript.py", line 250:

    exec _file_ in call_stack[-1].globals

  File "C:\dev\git\Marlin\buildroot\share\PlatformIO\scripts\common-dependencies.py", line 280:

    apply_features_config()

  File "C:\dev\git\Marlin\buildroot\share\PlatformIO\scripts\common-dependencies.py", line 112:

    if not env.MarlinFeatureIsEnabled(feature):

  File "C:\Users\speedster\.platformio\packages\tool-scons\script\..\engine\SCons\Environment.py", line 224:

    return self.method(*nargs, **kwargs)

  File "C:\dev\git\Marlin\buildroot\share\PlatformIO\scripts\common-dependencies.py", line 256:

    load_marlin_features()

  File "C:\dev\git\Marlin\buildroot\share\PlatformIO\scripts\common-dependencies.py", line 244:

    define_list = subprocess.check_output(cmd, shell=True).splitlines()

  File "c:\python27\lib\subprocess.py", line 223:

    raise CalledProcessError(retcode, cmd, output=output)

========================= [FAILED] Took 1.00 seconds =========================

Environment               Status    Duration

------------------------  --------  ------------

mega2560                  IGNORED

mega2560ext               IGNORED

mega1280                  IGNORED

MightyBoard1280           IGNORED

MightyBoard2560           IGNORED

rambo                     IGNORED

FYSETC_F6_13              IGNORED

FYSETC_F6_14              IGNORED

sanguino644p              IGNORED

sanguino1284p             IGNORED

melzi                     IGNORED

melzi_optiboot            IGNORED

melzi_optimized           IGNORED

at90usb1286_cdc           IGNORED

at90usb1286_dfu           FAILED    00:00:01.001

DUE                       IGNORED

DUE_USB                   IGNORED

DUE_debug                 IGNORED

DUE_archim                IGNORED

DUE_archim_debug          IGNORED

SAMD51_grandcentral_m4    IGNORED

LPC1768                   IGNORED

LPC1769                   IGNORED

STM32F103RC               IGNORED

STM32F103RC_meeb          IGNORED

STM32F103RC_fysetc        IGNORED

STM32F103RC_btt           IGNORED

STM32F103RC_btt_USB       IGNORED

STM32F103RC_btt_512K      IGNORED

STM32F103RC_btt_512K_USB  IGNORED

STM32F103RE               IGNORED

STM32F103RE_btt           IGNORED

STM32F103RE_btt_USB       IGNORED

STM32F4                   IGNORED

STM32F7                   IGNORED

ARMED                     IGNORED

STM32F103VE_GTM32         IGNORED

STM32F103VE_longer        IGNORED

mks_robin_mini            IGNORED

mks_robin_nano35          IGNORED

mks_robin                 IGNORED

mks_robin_stm32           IGNORED

mks_robin_pro             IGNORED

trigorilla_pro            IGNORED

mks_robin_e3              IGNORED

mks_robin_e3p             IGNORED

mks_robin_lite            IGNORED

mks_robin_lite3           IGNORED

jgaurora_a5s_a1           IGNORED

STM32F103CB_malyan        IGNORED

STM32F070RB_malyan        IGNORED

STM32F070CB_malyan        IGNORED

malyan_M300               IGNORED

chitu_f103                IGNORED

chitu_v5_gpio_init        IGNORED

STM32F103RET6_creality    IGNORED

STM32F401VE_STEVAL        IGNORED

FLYF407ZG                 IGNORED

FYSETC_S6                 IGNORED

STM32F407VE_black         IGNORED

BIGTREE_SKR_PRO           IGNORED

BIGTREE_GTR_V1_0          IGNORED

BIGTREE_BTT002            IGNORED

LERDGEX                   IGNORED

LERDGES                   IGNORED

LERDGEK                   IGNORED

rumba32                   IGNORED

esp32                     IGNORED

teensy31                  IGNORED

teensy35                  IGNORED

teensy36                  IGNORED

teensy41                  IGNORED

linux_native              IGNORED

include_tree              IGNORED

==================== 1 failed, 0 succeeded in 00:00:01.001 ====================

[10/02/20 10:23:58]

Although, there has been changes to the pins file as of 4 days ago, so it looks like this is just getting further and further away from unwinding the original issue. 🤷‍♂️

fiveangle commented 3 years ago

19592 opened to track new regression above introduced with #19468

Original compile failure reported remains if rolled immediately prior to 90bc1993b6811623dd9d0de00251e0c63415cb49

fiveangle commented 3 years ago

Applying #19733 compile is now back to similar as first failure mode I reported above:

avr-g++ -o .pio/build/at90usb1286_dfu/src/src/lcd/menu/menu_probe_offset.cpp.o -c -Wno-register -fno-exceptions -felide-constructors -std=gnu++11 -fpermissive -fsingle-precision-constant -fmax-errors=5 -g -fmerge-all-constants -Os -Wall -ffunction-sections -fdata-sections -mmcu=at90usb1286 -DPLATFORMIO=50001 -DTEENSY2PP -D__MARLIN_FIRMWARE__ -DUSB_SERIAL -DARDUINO=10805 -DTEENSYDUINO=153 -DCORE_TEENSY -DF_CPU=16000000L -DLAYOUT_US_ENGLISH -IMarlin -I/home/speedster/.platformio/packages/framework-arduinoteensy/libraries/PWMServo -I/home/speedster/.platformio/packages/framework-arduinoteensy/libraries/SD -I/home/speedster/.platformio/packages/framework-arduinoteensy/libraries/SD/utility -I/home/speedster/.platformio/packages/framework-arduinoteensy/libraries/Servo -I/home/speedster/.platformio/packages/framework-arduinoteensy/libraries/EEPROM -I/home/speedster/.platformio/packages/framework-arduinoteensy/libraries/SoftwareSerial -I.pio/libdeps/at90usb1286_dfu/U8glib-HAL/src -I/home/speedster/.platformio/packages/framework-arduinoteensy/libraries/Wire -I/home/speedster/.platformio/packages/framework-arduinoteensy/libraries/Wire/utility -I/home/speedster/.platformio/packages/framework-arduinoteensy/libraries/SPI -I/home/speedster/.platformio/packages/framework-arduinoteensy/cores/teensy -I/home/speedster/.platformio/packages/framework-arduinoteensy/cores Marlin/src/lcd/menu/menu_probe_offset.cpp
In file included from Marlin/src/lcd/menu/menu_advanced.cpp:31:0:
Marlin/src/lcd/menu/menu_advanced.cpp: In function 'void menu_dac()':
Marlin/src/lcd/menu/menu_advanced.cpp:75:39: error: 'dac_commit_eeprom' was not declared in this scope
     ACTION_ITEM(MSG_DAC_EEPROM_WRITE, dac_commit_eeprom);
                                       ^
Marlin/src/lcd/menu/menu_item.h:259:39: note: in definition of macro '_MENU_INNER_P'
     MenuItem_##TYPE::action(plabel, ##V);                      \
                                       ^
Marlin/src/lcd/menu/menu_item.h:354:57: note: in expansion of macro '_MENU_ITEM_P'
 #define MENU_ITEM_P(TYPE, PLABEL, V...)                 _MENU_ITEM_P(TYPE, false, PLABEL, ##V)
                                                         ^
Marlin/src/lcd/menu/menu_item.h:365:58: note: in expansion of macro 'MENU_ITEM_P'
 #define ACTION_ITEM_P(PLABEL, ACTION)                    MENU_ITEM_P(function, PLABEL, ACTION)
                                                          ^
Marlin/src/lcd/menu/menu_item.h:366:56: note: in expansion of macro 'ACTION_ITEM_P'
 #define ACTION_ITEM(LABEL, ACTION)                     ACTION_ITEM_P(GET_TEXT(LABEL), ACTION)
                                                        ^
Marlin/src/lcd/menu/menu_advanced.cpp:75:5: note: in expansion of macro 'ACTION_ITEM'
     ACTION_ITEM(MSG_DAC_EEPROM_WRITE, dac_commit_eeprom);
     ^
Marlin/src/lcd/menu/menu_advanced.cpp:75:39: error: 'dac_commit_eeprom' was not declared in this scope
     ACTION_ITEM(MSG_DAC_EEPROM_WRITE, dac_commit_eeprom);
                                       ^
Marlin/src/lcd/menu/menu_item.h:264:58: note: in definition of macro '_MENU_INNER_P'
       (encoderLine == _thisItemNr, _lcdLineNr, plabel, ##V);   \
                                                          ^
Marlin/src/lcd/menu/menu_item.h:354:57: note: in expansion of macro '_MENU_ITEM_P'
 #define MENU_ITEM_P(TYPE, PLABEL, V...)                 _MENU_ITEM_P(TYPE, false, PLABEL, ##V)
                                                         ^
Marlin/src/lcd/menu/menu_item.h:365:58: note: in expansion of macro 'MENU_ITEM_P'
 #define ACTION_ITEM_P(PLABEL, ACTION)                    MENU_ITEM_P(function, PLABEL, ACTION)
                                                          ^
Marlin/src/lcd/menu/menu_item.h:366:56: note: in expansion of macro 'ACTION_ITEM_P'
 #define ACTION_ITEM(LABEL, ACTION)                     ACTION_ITEM_P(GET_TEXT(LABEL), ACTION)
                                                        ^
Marlin/src/lcd/menu/menu_advanced.cpp:75:5: note: in expansion of macro 'ACTION_ITEM'
     ACTION_ITEM(MSG_DAC_EEPROM_WRITE, dac_commit_eeprom);
     ^
At global scope:
cc1plus: warning: unrecognized command line option '-Wno-register'
*** [.pio/build/at90usb1286_dfu/src/src/lcd/menu/menu_advanced.cpp.o] Error 1
========================== [FAILED] Took 3.62 seconds ==========================
sjasonsmith commented 3 years ago

I can confirm the issue still exists. Here are updated config files for current bugfix. Configuration.zip

fiveangle commented 3 years ago

Updated configs to 8bdde8d7a0b944bdf78421000c30d7eae68778d1

sjasonsmith commented 3 years ago

@fiveangle this has now merged with my change you tested.

I’m going to go ahead and close this. Please let us know if it breaks again.

github-actions[bot] commented 3 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.