Closed daleckystepan closed 3 years ago
Confirmed, mine is ignoring it as well now.
When reporting an issue, please be sure to follow all instructions at the top of the template, including debugging steps, and leave the sections headings intact.
For reference, these are the instructions included in the template:
Test with the bugfix-2.0.x
branch to see whether the issue still exists.
Get troubleshooting help from the Marlin community to confirm it's a bug and not just a configuration error. Links at https://github.com/MarlinFirmware/Marlin/issues/new/choose
Fill out every section of the template below.
Always attach configuration files, regardless of whether you think they are involved.
Read and understand Marlin's Code of Conduct. By filing an Issue, you are expected to comply with it, including treating everyone with respect: https://github.com/MarlinFirmware/Marlin/blob/master/.github/code_of_conduct.md
I have this problem too, on the latest bugfix-2.0.x
Sorry for that. Missing configuration files.
https://github.com/daleckystepan/Marlin/blob/geeetech_a10/Marlin/Configuration.h
https://github.com/daleckystepan/Marlin/blob/geeetech_a10/Marlin/Configuration_adv.h
I have this too, and the change @daleckystepan points to is definitely in the right area. Without being able to G34 and G29, my printer is unusable atm.
i have the same problem... Config.zip
I have the same issue, When undoing changes from commit 296a2ad it is working again
I have the same issue, When undoing changes from commit 296a2ad it is working again
I can confirm that this worked for me as well to solve the issues.
I'm having the same issue. If i use firmware from 11/24, it does work properly. So I'm guessing a recent change has broken it
Same here:
thanks in advance
If you are experiencing same issue just revert 296a2ad as mentioned in the first post.
If one of you has located the cause of the problem please post a pull request to fix it.
@daleckystepan But reverting is no solution to the root cause, in the long run.
And as apparent from this post https://github.com/MarlinFirmware/Marlin/commit/296a2ad7e45d88a10db4b3305ea183e5c0c177a5#r44537759 you seem to know the solution already. So please be kind enough, to
post a pull request to fix it.
as stated by @sjasonsmith. kind regards
not exactly related, but the new LEVEL_CORNERS_USE_PROBE ignores it also had to do that
- #define LEVEL_CORNERS_INSET_LFRB { 30, 30, 30, 30 } // (mm) Left, Front, Right, Back insets
+ #define LEVEL_CORNERS_INSET_LFRB { 40, 30, 20, 30 } // (mm) Left, Front, Right, Back insets
@daleckystepan thanks for your help troubleshooting this. I've merged the simplified fix in your PR, which seems to fix it. I'll leave this open until you have a chance to test it and verify it is working from the bugfix-2.0.x
branch.
Corrected my issue. Fast work. Thanks.
Closing, based on feedback from a couple people that it is now working. Please let us know if there are still issues related to this.
Fixed also for me. Thank you for quick solution.
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Bug Description
Nozzle to probe offset is ignored. Probably on X and Y axis.
Configuration Files
Not relevant
Steps to Reproduce
Compile latest 04c4c6004e752582235357b14aebdd5ff579f477 bugfix with bed leveling support.
Expected behavior:
Nozzle to probe offset will be correctly applied
Actual behavior:
Nozzle to probe offset is ignored.
Additional Information
Reverting 296a2ad7e45d88a10db4b3305ea183e5c0c177a5 this commit will fix the issue. Here is the issue
Probe::offset is copied and then referenced instead of just referenced.