search

MarlinFirmware / Marlin

Marlin is an optimized firmware for RepRap 3D printers based on the Arduino platform. Many commercial 3D printers come with Marlin installed. Check with your vendor if you need source code for your specific machine.
https://marlinfw.org
GNU General Public License v3.0
16.18k stars 19.21k forks source link

[BUG] Can't compile for Ender 3 V2 with AUTO_BED_LEVELING_(BI)LINEAR uncommented. #22588

Closed lefterisgar closed 3 years ago

lefterisgar commented 3 years ago

Did you test the latest bugfix-2.0.x code?

Yes, and the problem still exists.

Bug Description

PlatformIO refuses to compile with the following error(s):

Compiling .pio\build\STM32F103RET6_creality\src\src\lcd\e3v2\creality\dwin.cpp.o
Marlin\src\lcd\e3v2\creality\dwin.cpp: In function 'void Item_Adv_ProbeOffsets(uint8_t)':
Marlin\src\lcd\e3v2\creality\dwin.cpp:2429:33: error: too many arguments to function 'void say_probe_offs_en(uint8_t)'
 2429 |         say_probe_offs_en(0, row);
      |                                 ^
Marlin\src\lcd\e3v2\creality\dwin.cpp:567:6: note: declared here
  567 | void say_probe_offs_en(const uint8_t row) {
      |      ^~~~~~~~~~~~~~~~~
*** [.pio\build\STM32F103RET6_creality\src\src\lcd\e3v2\creality\dwin.cpp.o] Error 1

Bug Timeline

It started with commit 09af42e (17-08-2021).

Expected behavior

I expected to be able to successfully compile Marlin firmware with the options below (steps to reproduce) enabled.

Actual behavior

Compiling .pio\build\STM32F103RET6_creality\src\src\lcd\e3v2\creality\dwin.cpp.o fails.

Steps to Reproduce

  1. Clone Marlin.
  2. Import Ender 3 V2 configurations.
  3. Uncomment #define BLTOUCH.
  4. Uncomment #define Z_SAFE_HOMING.
  5. Uncomment any of these:
    • //#define AUTO_BED_LEVELING_3POINT
    • //#define AUTO_BED_LEVELING_LINEAR
    • //#define AUTO_BED_LEVELING_BILINEAR
  6. Compile Marlin.

Version of Marlin Firmware

Latest bugfix 2.0.x

Printer model

Creality Ender 3 V2

Electronics

Add-ons

BLTouch, Filament run-out sensor

Bed Leveling

ABL Bilinear mesh

Additional information & file uploads

Configs.zip image

I went to line 2429 of dwin.cpp and changed it from say_probe_offs_en(0, row); to say_probe_offs_en(row); and it did successfully compile.

ellensp commented 3 years ago

This PR broke it https://github.com/MarlinFirmware/Marlin/pull/22586

ellensp commented 3 years ago

Issues resulting from Clean up CrealityUI and MarlinUI #22586 No change with " Followup to CrealityUI cleanup" https://github.com/MarlinFirmware/Marlin/commit/11e8cd9db938fcc5ee5c5234f148655a8f19c20d

lefterisgar commented 3 years ago

Well, thank you soo much!! Really appreciate your help!

lefterisgar commented 3 years ago

Closure was accidental.

rankinstudio commented 3 years ago

I just ran into this bug as well, any fix?

lefterisgar commented 3 years ago

No and I guess till the E3V2 cleanup ends we will be having a lot of issues like this...

thinkyhead commented 3 years ago

We'll see about "a lot." Meanwhile I can quickly patch this as soon as I get back from the grocery store.

lefterisgar commented 3 years ago

Nice! Accidents always happen and it's not your fault. Having to maintain such a big codebase is rocket science to me and a lot of other people... 😁 Really appreciate your job and looking forward to the end of the cleanup!

github-actions[bot] commented 2 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.