MarlinFirmware / Marlin

Marlin is an optimized firmware for RepRap 3D printers based on the Arduino platform. Many commercial 3D printers come with Marlin installed. Check with your vendor if you need source code for your specific machine.
https://marlinfw.org
GNU General Public License v3.0
16.14k stars 19.2k forks source link

[BUG] (Compilation error when enable CHAMBER_FAN) #22615

Closed diogoc closed 2 years ago

diogoc commented 3 years ago

Did you test the latest bugfix-2.0.x code?

Yes, and the problem still exists.

Bug Description

When enable the CHAMBER_FAN without enable the AUTO_FAN it gives a compilation error CHAMBER_FAN_INDEX not defined.

The chamber fan is limited to 225.

Bug Timeline

No response

Expected behavior

The chamber fan should not need the auto fan to work.

Max value of chamber fan should be 255.

Actual behavior

Gives a compilation error CHAMBER_FAN_INDEX not defined.

NOMORE(fan_chamber_pwm, 225) in temperature.cpp should be NOMORE(fan_chamber_pwm, 255)

Steps to Reproduce

No response

Version of Marlin Firmware

Marlin Bugfix-2.0.x 2021-08-21

Printer model

No response

Electronics

No response

Add-ons

No response

Bed Leveling

No response

Your Slicer

No response

Host Software

No response

Additional information & file uploads

It would be good if it was possible to configure the pin used for the chamber fan.

sjasonsmith commented 2 years ago

I don't think the compilation error still exists. If it's still an issue you'd need to attach an example config file to reproduce it.

I posted a PR to increase the maximum to 255 and remove a comment which is no longer valid.

ladismrkolj commented 2 years ago

I looked into the CHAMBER_FAN_INDEX I added some code into the temperature.cpp to fix it. If it works as expected I will do a pull request.

thisiskeithb commented 2 years ago

https://github.com/MarlinFirmware/Marlin/pull/23262 has been merged.

github-actions[bot] commented 2 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.