search

MarlinFirmware / Marlin

Marlin is an optimized firmware for RepRap 3D printers based on the Arduino platform. Many commercial 3D printers come with Marlin installed. Check with your vendor if you need source code for your specific machine.
https://marlinfw.org
GNU General Public License v3.0
16.19k stars 19.22k forks source link

[BUG] X and Y axis remain trusted after a M84, only Z axis is marked as untrusted #23095

Open mriscoc opened 2 years ago

mriscoc commented 2 years ago

Did you test the latest bugfix-2.0.x code?

Yes, and the problem still exists.

Bug Description

Tested in Ender3v2 with the last bugfix:

Do an auto home (G28) and wait to finish and disable steppers with M84. The system indicates X and Y axis as trusted, and Z as untrusted.

Bug Timeline

No response

Expected behavior

All axes will be marked as untrusted after an M84

Actual behavior

only Z axis will be marked as untrusted after an M84

Steps to Reproduce

Do an auto home (G28) and wait to finish and disable steppers with M84. The system indicates X and Y axis as trusted, and Z as untrusted.

Version of Marlin Firmware

Latest bugfix 2.0.x

Printer model

Creality Ender 3v2

Electronics

STM32F103RET6

Add-ons

none

Bed Leveling

No response

Your Slicer

No response

Host Software

No response

Additional information & file uploads

No response

github-actions[bot] commented 2 years ago

This issue has had no activity in the last 60 days. Please add a reply if you want to keep this issue active, otherwise it will be automatically closed within 10 days.

mriscoc commented 2 years ago

was this bug fixed?

thisiskeithb commented 2 years ago

was this bug fixed?

Your PR is still pending, so probably not.

github-actions[bot] commented 2 years ago

This issue has had no activity in the last 60 days. Please add a reply if you want to keep this issue active, otherwise it will be automatically closed within 10 days.

zinen commented 2 years ago

Testing this on Ender5 Pro gives the same issue.

Martian-35 commented 1 year ago

The Z axis remains trusted now too. If the gantry is lowered manually and then you run a probe cycle, it crashes.

Farva42 commented 1 year ago

I started looking at this. When m84 is called it will only try and set the Z axis to disabled but all axis will be disabled regardless of the flag not being set. If you call G28 after X&Y will still show trusted with Z showing untrusted but it will not do a z raise before attempting to home.

If you do two M84's in a row the second one will correctly set all three axis to disabled and set all three to untrusted but a G28 after will still act like all axis are trusted and neglect to do a Z raise.

classicrocker883 commented 5 months ago

this issue is still present.