[BUG] (STOP button does not stop/reset the print status)

Dentrax commented 2 years ago

Did you test the latest `bugfix-2.0.x` code?

No, but I will test it now!

Bug Description

Pressing the Stop button stops the printing, but it's impossible to print the same model since the progress/status does not reset. (Which it was working as expected in v1.0.1)

I just upgraded my Marlin from v1.0.1 to latest.

P.S: I used the corresponding configs: https://github.com/MarlinFirmware/Configurations/tree/2.0.9.3/config/examples/Creality/Ender-3%20V2

Bug Timeline

No response

Expected behavior

It should reset the print status.

Actual behavior

It does not reset the print status. It seems like I clicked the pause button and wanted to resume the print.

The only workaround to print the same model from the beginning is that rebooting the printer by shutting it down.

Steps to Reproduce

Start a print
After some progress complete, press the "Stop" button
Try to select the same model again to print and see that progress is not changed

Version of Marlin Firmware

2.0.9.3

Printer model

Creality Ender 3 V2

Electronics

Stock

Add-ons

No response

Bed Leveling

No Bed Leveling

Your Slicer

Cura

Host Software

SD Card (headless)

Additional information & file uploads

https://user-images.githubusercontent.com/16493751/147976519-2757ef75-6b18-40a3-80e5-0ea57181093c.mp4

thinkyhead commented 2 years ago

Does it work properly with 2.0.9.2 … or 2.0.9.1 ?

Dentrax commented 2 years ago

Does it work properly with 2.0.9.2 … or 2.0.9.1 ?

I directly jumped from v1.0.1 so I'm not sure. 🤷‍♂️

thinkyhead commented 2 years ago

Well if you get a chance to try either one out, please report your results. I am quite behind in dealing with issues and submissions at this time, so I will not able to devote any time to in-depth testing this week.

descipher commented 2 years ago

Is that screen still closed source? If so we can't do anything with it ..

Dentrax commented 2 years ago

Is that screen still closed source? If so we can't do anything with it ..

By saying "closed source", you mean T5UIC1_V20_4页面_191022.BIN file that included in DWIN_SET?

The-EG commented 2 years ago

Which UI is this? It would be one of:

#define DWIN_CREALITY_LCD             // Creality UI
//#define DWIN_CREALITY_LCD_ENHANCED  // Enhanced UI
//#define DWIN_CREALITY_LCD_JYERSUI

with the default in the example being 'Creality UI'.

The-EG commented 2 years ago

Is that screen still closed source? If so we can't do anything with it ..

Not exactly, this DWIN is much simpler than others. Assets (images, icons) are stored on the LCD itself and it can be commanded to display them, via serial interface. There are no built in menus, dialogs, etc.

There are currently 4 different UIs for this screen, however, and the UI pictured could be the stock 'CreaityUI' or either of the two derivatives, 'Enhanced' or 'Jyers'. Assuming this is a bug, the fix will need to be performed for the UI in question.

descipher commented 2 years ago

Is that screen still closed source? If so we can't do anything with it ..

Not exactly, this DWIN is much simpler than others. Assets (images, icons) are stored on the LCD itself and it can be commanded to display them, via serial interface. There are no built in menus, dialogs, etc.

There are currently 4 different UIs for this screen, however, and the UI pictured could be the stock 'CreaityUI' or either of the two derivatives, 'Enhanced' or 'Jyers'. Assuming this is a bug, the fix will need to be performed for the UI in question.

Very good, there are some encrypted ones .. you can't work with them.

mriscoc commented 2 years ago

Which UI is this? It would be one of:
#define DWIN_CREALITY_LCD             // Creality UI
//#define DWIN_CREALITY_LCD_ENHANCED  // Enhanced UI
//#define DWIN_CREALITY_LCD_JYERSUI
with the default in the example being 'Creality UI'.

Seems to be the DWIN_CREALITY_LCD flavor.

Add this: To the dwin.cpp file

thisiskeithb commented 2 years ago

Fixed in #23481

github-actions[bot] commented 2 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

MarlinFirmware / Marlin