ellensp
commented
2 years ago vscode + platformio takes 10 seconds to compile ardduino ide 2m52 on same hardware! Do yourself a favor and use vscode with platformio
Closed EbbiDos closed 2 years ago
ellensp
commented
2 years ago vscode + platformio takes 10 seconds to compile ardduino ide 2m52 on same hardware! Do yourself a favor and use vscode with platformio
ellensp
commented
2 years ago In saying that... here is the fix. 3 issues in total.
diff --git a/Marlin/src/lcd/e3v2/enhanced/dwin_popup.cpp b/Marlin/src/lcd/e3v2/enhanced/dwin_popup.cpp
index 89909e5c27..2f9734a90b 100644
--- a/Marlin/src/lcd/e3v2/enhanced/dwin_popup.cpp
+++ b/Marlin/src/lcd/e3v2/enhanced/dwin_popup.cpp
@@ -27,6 +27,10 @@
* Date: 2021/11/06
*/
+
+#include "../../../inc/MarlinConfigPre.h"
+#if ENABLED(DWIN_CREALITY_LCD_ENHANCED)
+
#include "dwin.h"
#include "dwin_popup.h"
@@ -53,3 +57,4 @@ void DWIN_Popup_ConfirmCancel(const uint8_t icon, FSTR_P const fmsg2) {
Draw_Select_Highlight(true);
DWIN_UpdateLCD();
}
+#endif
diff --git a/Marlin/src/module/probe.h b/Marlin/src/module/probe.h
index 3c97afcb89..d9c50b0125 100644
--- a/Marlin/src/module/probe.h
+++ b/Marlin/src/module/probe.h
@@ -212,14 +212,14 @@ public:
// constexpr helpers used in build-time static_asserts, relying on default probe offsets.
class build_time {
- static constexpr xyz_pos_t default_probe_xyz_offset =
+ static constexpr xyz_pos_t default_probe_xyz_offset = xyz_pos_t(
#if HAS_BED_PROBE
NOZZLE_TO_PROBE_OFFSET
#else
{ 0 }
#endif
- ;
- static constexpr xy_pos_t default_probe_xy_offset = { default_probe_xyz_offset.x, default_probe_xyz_offset.y };
+ );
+ static constexpr xy_pos_t default_probe_xy_offset = xy_pos_t({ default_probe_xyz_offset.x, default_probe_xyz_offset.y });
public:
static constexpr bool can_reach(float x, float y) {
thisiskeithb
commented
2 years ago https://github.com/MarlinFirmware/Marlin/pull/23510 has been merged.
github-actions[bot]
commented
2 years ago This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Did you test the latest
bugfix-2.0.xcode?Yes, and the problem still exists.
Bug Description
When compiling Marlin 2.0.93 with Arduino IDE 1.8.19 for an Arduino Due with RADDS shield I get the following compiler error:
I attached my config files. Marlin_Config.zip
Before reporting this issue I've checked previous bug reports and found #16767. Mine seems very similar.
I've tested it on two different computers with the same result. On my laptop I've even tested with a clean installation of everything (including Windows10).
Works for the standard board BOARD_RAMPS_14_EFB when applying neccessary changes in both configs (reducing MIXING_STEPPERS in MIXING_EXTRUDER to 2 and deactivating USE_CONTROLLER_FAN). But it doesn't work for BOARD_RAMPS_DUO_EFB.
Bug Timeline
On first try with Marlin 2.0.93
Expected behavior
No compilation errors
Actual behavior
Compiler Error maybe type cast errors in compiler definitions
Steps to Reproduce
Thats what I did on my laptop:
Version of Marlin Firmware
2.0.93
Printer model
Delta
Electronics
Arduino Due with RADDS shield
Add-ons
BLtouch
Bed Leveling
UBL Bilinear mesh
Your Slicer
Simplify3D
Host Software
OctoPrint
Additional information & file uploads
No response