Closed martindecz closed 2 years ago
replace #if HAS_TEMPERATURE && EITHER(HAS_MARLINUI_MENU, HAS_DWIN_E3V2) In Conditionals_post.h with #if HAS_TEMPERATURE && ANY(HAS_MARLINUI_MENU, HAS_DWIN_E3V2, HAS_DGUS_LCD_CLASSIC)
This PR fixes it.
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Did you test the latest
bugfix-2.0.x
code?Yes, and the problem still exists.
Bug Description
In Conditionals_post.h `#if HAS_TEMPERATURE && EITHER(HAS_MARLINUI_MENU, HAS_DWIN_E3V2)
ifdef PREHEAT_6_LABEL
elif defined(PREHEAT_5_LABEL)
elif defined(PREHEAT_4_LABEL)
elif defined(PREHEAT_3_LABEL)
elif defined(PREHEAT_2_LABEL)
elif defined(PREHEAT_1_LABEL)
endif
if PREHEAT_COUNT && ANY(HAS_HOTEND, HAS_HEATED_BED, HAS_FAN)
endif
endif
if !HAS_PREHEAT
undef PREHEAT_SHORTCUT_MENU_ITEM
undef DGUS_PREHEAT_UI
endif
HAS_MARLINUI_MENU was LCD before and DGUS_PREHEAT_UI works fine, but with new version if i enable DGUS_LCD_UI_MKS in Configuration.h, then in ..\lcd\extui\dgus\DGUSScreenHandler.cpp i cannot work with preheat because from Configuration.h/adv is DGUS_PREHEAT_UI enabled, but with this in Conditionals_post.h is disabled, with no reason. Shouldn't be there
#if HAS_TEMPERATURE && EITHER(EXTENSIBLE_UI, HAS_DWIN_E3V2)`?Bug Timeline
found it in new builds, last working build was from 10.11.2021
Expected behavior
ENABLED(DGUS_PREHEAT_UI) really enabled
Actual behavior
ENABLED(DGUS_PREHEAT_UI) disabled
Steps to Reproduce
Version of Marlin Firmware
02010000
Printer model
Fox MK1
Electronics
does not matter
Add-ons
does not matter
Bed Leveling
UBL Bilinear mesh
Your Slicer
Simplify3D
Host Software
SD Card (headless)
Additional information & file uploads
None