MarlinFirmware / Marlin

Marlin is an optimized firmware for RepRap 3D printers based on the Arduino platform. Many commercial 3D printers come with Marlin installed. Check with your vendor if you need source code for your specific machine.
https://marlinfw.org
GNU General Public License v3.0
16.19k stars 19.21k forks source link

[FR] Show only remaining time on Ender 3 V2 DWIN_MARLINUI #25135

Open RustedAperture opened 1 year ago

RustedAperture commented 1 year ago

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

When disabling elapsed time by commenting it out, it still shows on the ender 3 v2 display. Have not tested with other displays.

I have enabled only remaining time but elapsed still shows.

Bug Timeline

not sure

Expected behavior

only remaining time to show

Actual behavior

cycles between remaining and elapsed

Steps to Reproduce

  1. comment out #define SHOW_ELAPSED_TIME
  2. remove comment from #define SHOW_REMAINING_TIME

Version of Marlin Firmware

2022-12-21

Printer model

Ender 3 V2

Electronics

SKR Mini E3 V2, Stock Ender 3 screen

Add-ons

BLTouch

Bed Leveling

UBL Bilinear mesh

Your Slicer

Prusa Slicer

Host Software

OctoPrint

Don't forget to include

Additional information & file uploads

Marlin.zip

github-actions[bot] commented 1 year ago

This issue has had no activity in the last 60 days. Please add a reply if you want to keep this issue active, otherwise it will be automatically closed within 10 days.

RustedAperture commented 1 year ago

Bump

ellensp commented 1 year ago

running DWIN_MARLINUI_PORTRAIT on Stock Ender 3 V2 screen

ellensp commented 1 year ago

looking at https://github.com/MarlinFirmware/Marlin/blob/bugfix-2.1.x/Marlin/src/lcd/e3v2/marlinui/ui_status_480x272.cpp#L369-L422

From looking at the code this is simply not been implemented yet

RustedAperture commented 1 year ago

running DWIN_MARLINUI_PORTRAIT on Stock Ender 3 V2 screen

Yes, sorry should have specified since there are multiple available for the DWIN E3V2 screen.

RustedAperture commented 1 year ago

looking at https://github.com/MarlinFirmware/Marlin/blob/bugfix-2.1.x/Marlin/src/lcd/e3v2/marlinui/ui_status_480x272.cpp#L369-L422

From looking at the code this is simply not been implemented yet

Is it ok to change the title to [FR] then?

ellensp commented 1 year ago

Yes I think that would be appropriate.