search

MarlinFirmware / Marlin

Marlin is an optimized firmware for RepRap 3D printers based on the Arduino platform. Many commercial 3D printers come with Marlin installed. Check with your vendor if you need source code for your specific machine.
https://marlinfw.org
GNU General Public License v3.0
16.19k stars 19.21k forks source link

[BUG] TFT portrait mode does not work on MKS Robin TFT v1.x #25357

Closed jmz52 closed 1 year ago

jmz52 commented 1 year ago

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

MKS Robin TFT v1.x with ILI9328 and R61505 have initialization code for landscape screen orientation only.

#if TFT_ROTATION == TFT_ROTATE_180
  #define ILI9328_DRVCTL_DATA        0x0000
  #define ILI9328_GATE_SCANCTL1_DATA 0xA700
#else
  #define ILI9328_DRVCTL_DATA        ILI9328_DRVCTL_SS
  #define ILI9328_GATE_SCANCTL1_DATA 0x2700
#endif

#define ILI9328_ETMOD_ORIENTATION (ILI9328_ETMOD_AM | ILI9328_ETMOD_ID1 | ILI9328_ETMOD_ID0)
#if TFT_ROTATION == TFT_ROTATE_180
  #define R61505_DRVCTL_DATA      0x0000
  #define R61505_DRVCTRL_DATA     (0x2700 | R61505_DRVCTRL_GS)
#else
  #define R61505_DRVCTL_DATA      R61505_DRVCTL_SS
  #define R61505_DRVCTRL_DATA     0x2700
#endif

#define R61505_ETMOD_ORIENTATION (R61505_ETMOD_AM | R61505_ETMOD_ID0 | R61505_ETMOD_ID1)

Looking for owners of these old screens who are willing to test code on their boards.

Version of Marlin Firmware

bugfix-2.1.x

Electronics

MKS Robin v2.x with MKS Robin TFT v1.x

Add-ons

320x240 screen with ILI9328 or R61505 controllers

github-actions[bot] commented 1 year ago

This issue has had no activity in the last 60 days. Please add a reply if you want to keep this issue active, otherwise it will be automatically closed within 10 days.

github-actions[bot] commented 1 year ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.