search

MarlinFirmware / Marlin

Marlin is an optimized firmware for RepRap 3D printers based on the Arduino platform. Many commercial 3D printers come with Marlin installed. Check with your vendor if you need source code for your specific machine.
https://marlinfw.org
GNU General Public License v3.0
16.31k stars 19.25k forks source link

[BUG] Compilation error with DWIN_CREALITY_LCD_JYERSUI (error: 'MSG_MAIN_MENU' is not a member of 'Language_en'; ) #26188

Closed stoubian closed 1 year ago

stoubian commented 1 year ago

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

With DWIN_CREALITY_LCD_JYERSUI defined, When compiling in VSCode with PIO, The compiler throws the error: 'MSG_MAIN_MENU' is not a member of 'Language_en'; did you mean 'MSG_MMU2_MENU'?

The fix proposed on reddit by nanmetal worked fine after test. link here

I make a PR asap

Bug Timeline

new

Expected behavior

I expect the code compiles without error.

Actual behavior

The compiler throws the error: 'MSG_MAIN_MENU' is not a member of 'Language_en'; did you mean 'MSG_MMU2_MENU'?

Steps to Reproduce

  1. take the example default configuration.h file or any configuration.h file
  2. uncomment DWIN_CREALITY_LCD_JYERSUI
  3. compile
  4. error

Version of Marlin Firmware

2.1.2.1

Printer model

Creality Ender-3 V2

Electronics

Stock electronics

Add-ons

No response

Bed Leveling

UBL Bilinear mesh

Your Slicer

Prusa Slicer

Host Software

SD Card (headless)

Don't forget to include

Additional information & file uploads

No response

thisiskeithb commented 1 year ago

Are you using a fork? MSG_MAIN_MENU is in the language file(s):

https://github.com/MarlinFirmware/Marlin/blob/1d17c34e123f74d820f42fcd179104c884719007/Marlin/src/lcd/language/language_en.h#L76

Using the stock Ender-3 V2 Creality UI config and enabling DWIN_CREALITY_LCD_JYERSUI instead of DWIN_CREALITY_LCD works fine.

stoubian commented 1 year ago

I am using the code revision at tag 2.1.2.1 and the error is in that version but I see it has been fixed by this commit on the branch bugfix-2.1.x : link to the commit

thisiskeithb commented 1 year ago

I am using the code revision at tag 2.1.2.1 and the error is in that version but I see it has been fixed by this commit on the branch bugfix-2.1.x : link to the commit

That's why we ask if you've tested the latest bugfix-2.1.x before opening up new issues:

Did you test the latest bugfix-2.1.x code? Yes, and the problem still exists.

stoubian commented 1 year ago

My bad, I don't know why I was thinking that tag 2.1.2.1 was in advance of branch bugfix-2.1.x but this is clearly not the case 😅 Thanks for your fast answer (and for maintianing the project)!

github-actions[bot] commented 1 year ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.