MarlinFirmware / Marlin

Marlin is an optimized firmware for RepRap 3D printers based on the Arduino platform. Many commercial 3D printers come with Marlin installed. Check with your vendor if you need source code for your specific machine.
https://marlinfw.org
GNU General Public License v3.0
16.18k stars 19.21k forks source link

[BUG] DGUS_LCD_UI_RELOADED not compiling Marlin 2.1.2.2 #26859

Closed Ale11Re closed 5 months ago

Ale11Re commented 6 months ago

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

When selecting DGUS_LCD_UIRELOADED to compile with CR10s Pro. I'm providing my configurations. It does compile with Marlin 2.1.2.1. I did also try with latest Marlin bugfix 2.1.x but does not compile due to other errors. Compilation error: ExtUI not defined. When commenting line 111 of /src/feature/powerloss.cpp "TERN(EXTENSIBLE_UI, ExtUI::onSetPowerLoss(enabled));" It compiles fine. Screenshot 2024-03-10 200256

Bug Timeline

No response

Expected behavior

Expect Marlin 2.1.2.2 to compile

Actual behavior

Marlin 2.1.2.2 won't compile

Steps to Reproduce

With

Version of Marlin Firmware

2.1.2.2

Printer model

Creality CR10S Pro

Electronics

No response

LCD/Controller

DGUS_LCD_UI_RELOADED

Other add-ons

No response

Bed Leveling

None

Your Slicer

None

Host Software

None

Don't forget to include

Additional information & file uploads

Conf.zip

ellensp commented 6 months ago

The ExtUI headers are not included...

apply this diff

diff --git a/Marlin/src/feature/powerloss.cpp b/Marlin/src/feature/powerloss.cpp
index 86e6b780bd..69e23f4a32 100644
--- a/Marlin/src/feature/powerloss.cpp
+++ b/Marlin/src/feature/powerloss.cpp
@@ -31,6 +31,10 @@
 #include "powerloss.h"
 #include "../core/macros.h"

+#if ENABLED(EXTENSIBLE_UI)
+  #include "../lcd/extui/ui_api.h"
+#endif
+
 bool PrintJobRecovery::enabled; // Initialized by settings.load()

 MediaFile PrintJobRecovery::file;
ellensp commented 6 months ago

Issue is not present in bugfix 2.1.x

Ale11Re commented 6 months ago

My bad, if not present in bugfix I screwed up something else

thisiskeithb commented 5 months ago

Closing since this is already fixed in bugfix-2.1.x.

thisiskeithb commented 4 months ago

Patch for 2.1.x submitted:

github-actions[bot] commented 2 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.