MarlinFirmware / Marlin

Marlin is an optimized firmware for RepRap 3D printers based on the Arduino platform. Many commercial 3D printers come with Marlin installed. Check with your vendor if you need source code for your specific machine.
https://marlinfw.org
GNU General Public License v3.0
16.14k stars 19.2k forks source link

[BUG] Compilation error: MPCTEMP_START defined in dwin.h, but used in temperature.cpp when EXTENSIBLE_UI is enabled #26997

Closed rondlh closed 4 months ago

rondlh commented 4 months ago

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

MPCTEMP_START is defined in dwin.h, but used in temperature.cpp when EXTENSIBLE_UI and MPC_AUTOTUNE are enabled, this causes a compilation error when you don't use DWIN_CREALITY_LCD.

Marlin\src\module\temperature.cpp: error: 'MPCTEMP_START' is not a member of 'ExtUI::mpcresultt' 1230 | TERN(EXTENSIBLE_UI, ExtUI::onMPCTuning(ExtUI::mpcresult_t::MPCTEMP_START));

Bug Timeline

Recent update (last 2 weeks I guess)

Expected behavior

No compilation error

Actual behavior

Compilation error: Marlin\src\module\temperature.cpp: error: 'MPCTEMP_START' is not a member of 'ExtUI::mpcresultt' 1230 | TERN(EXTENSIBLE_UI, ExtUI::onMPCTuning(ExtUI::mpcresult_t::MPCTEMP_START));

Steps to Reproduce

  1. Enable EXTENSIBLE_UI and MPC_AUTOTUNE
  2. Compile the source

Version of Marlin Firmware

Bugfix-2.1.x April 21 2024

Printer model

Custom

Electronics

MKS Monster8 V1.0

LCD/Controller

BTT TFT35 V3.0

Other add-ons

MKS EBB42 CAN Toolhead, BLTouch 3.1

Bed Leveling

ABL Bilinear mesh

Your Slicer

None

Host Software

None

Don't forget to include

Additional information & file uploads

Configuration_adv.zip

ellensp commented 4 months ago

The point of asking for config files is so we have something we can drop in and run to reproduce the issue.

Your configs do not do this, they are not usable, infact they reference UI code that is not even in stock marlin.

ellensp commented 4 months ago

A simple config that will trigger the error and builds Configuration.zip

ellensp commented 4 months ago

This PR fixes it

rondlh commented 4 months ago

The point of asking for config files is so we have something we can drop in and run to reproduce the issue.

Your configs do not do this, they are not usable, infact they reference UI code that is not even in stock marlin.

Sorry, I understand your point, will do better next time.

github-actions[bot] commented 2 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.