MarlinFirmware / Marlin

Marlin is an optimized firmware for RepRap 3D printers based on the Arduino platform. Many commercial 3D printers come with Marlin installed. Check with your vendor if you need source code for your specific machine.
https://marlinfw.org
GNU General Public License v3.0
15.95k stars 19.08k forks source link

[2.1.x] 🐛 Fix bool evalution of XYval and similar types #27026

Closed thisiskeithb closed 1 week ago

thisiskeithb commented 2 weeks ago

Description

[!IMPORTANT]
This is a 2.1.x-specific patch for board lockup and bootloops with Input Shaping among other things. Originally submitted to bugfix-2.1.x by @sjasonsmith in https://github.com/MarlinFirmware/Marlin/pull/26936

And if you're asking why this didn't affect bugfix-2.1.x, it's because:

The reason this specific bug behaviour does not occur in bugfix appears to be that the variable in question (step_needed in function Stepper::shaping_isr()) has changed type from xy_bool_t to AxisFlags.

Originally posted by @tombrazier in https://github.com/MarlinFirmware/Marlin/issues/26811#issuecomment-2041060625


Verified that board bootloops and lockups are gone on an SKR 1.4 with INPUT_SHAPING_X and INPUT_SHAPING_Y enabled.

Requirements

Marlin 2.1.x

Benefits

Marlin 2.1.x will include this patch on the next release.

Related Issues

Related Issues