Ender 2 Pro LCD_PINS_RS = PB15

[jam-berg]

added missing LCD_PINS_RS for Ender 2 Pro BOARD_CREALITY_ENDER2P_V24S4 and set to PB15

I tested it on the Ender 2 Pro and the LCD is now working. Before, just de backlight of the LCD was turned on but no image.

Description

This Pull Request defines the PB15 Pin, that is used as EXP_07 and then assigned to LCD_PINS_RS. This is for the BOARD_CREALITY_ENDER2P_V24S4. The information was extracted from the Creality repository https://github.com/CrealityOfficial/Ender-2-Pro/tree/MCU_HDSC and tested on the Ender 2 Pro

Requirements

• CR-10 LCD
• BOARD_CREALITY_ENDER2P_V24S4

Benefits

This pull request makes the LCD of the Ender 2 Pro functional.

Configurations

Default Config files of the Marlin Config repository for this board.

[thisiskeithb]

PB15 was removed on purpose in https://github.com/MarlinFirmware/Marlin/pull/26908 so perhaps there is different LCD hardware in use / different requirements?

[thinkyhead]

The version referred to in that PR was CR-FDM-V2.4.S4.170 …. Do you have a board with the identical number or is there some difference?

[ellensp]

back of the physical board, note the NCC pin

and here is the front for the board number CR-FDM-v2.4.S4.170

[shadow578]

Hi there,

chipping in since this PR originated from a issue created on my dev repo https://github.com/shadow578/Marlin-H32/issues/61.

from what i can tell, https://github.com/MarlinFirmware/Marlin/issues/26903 was caused by redefinition of PC1 as both KILL_PIN and X_STEP_PIN, and not by PB15 being assigned to the LCD.

the removal of EXP1_07_PIN = PB15 was done according to the pinout at https://gist.github.com/SteveGotthardt/33bdef27d1430f62b4fee5d723d0cde9, which states that EXP1_07_PIN is "NCC" = No Connection. but perhaps this isn't right, and "NCC" is "(Negative) Chip Control" (= NSS). https://github.com/MarlinFirmware/Marlin/blob/a22155bd96104d9040972e43c720668230820359/Marlin/src/pins/hc32f4/pins_CREALITY_ENDER2P_V24S4.h#L178

So maybe this isn't a different board revision, but the same revision and the pinout provided by @SteveGotthardt is incorrect.

[ellensp]

Need someone with the actual board to check it. Since the information available is in conflict.

But im inclined to think that n/c is not correct and ncc meant something else

[jam-berg]

Here is the pin definition from the creality build: https://github.com/CrealityOfficial/Ender-2-Pro/blob/MCU_HDSC/source/Marlin/src/pins/stm32f1/pins_CREALITY_V428.h

[jam-berg]

And the front of my board:

[ellensp]

I asked SteveGotthardt to verify this pin on his board. He has confirmed that pin EXP1_07_PIN (NCC) should be PB15

@thinkyhead please revert the ENDER2_PRO_REV_QQQ variant code and add this change