search

MarlinFirmware / Marlin

Marlin is an optimized firmware for RepRap 3D printers based on the Arduino platform. Many commercial 3D printers come with Marlin installed. Check with your vendor if you need source code for your specific machine.
https://marlinfw.org
GNU General Public License v3.0
16.27k stars 19.23k forks source link

[BUG] error: 'ENCODER_5X_STEPS_PER_SEC' was not declared in this scope in latest compile for Monoprice Maker Select V2 #27093

Closed william-orange closed 5 months ago

william-orange commented 5 months ago

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

Can not compile for Monoprice Maker Select V@ using latest bugfix. The error is Marlin\src\lcd\marlinui.cpp:1050:24: error: 'ENCODER_5X_STEPS_PER_SEC' was not declared in this scope

Bug Timeline

Problem appeared 5/14/2024

Expected behavior

Expected compile wit no error

Actual behavior

Compile failed as shown

Steps to Reproduce

attempt compile

Version of Marlin Firmware

latest bugfix

Printer model

Monoprice Maker Select V2

Electronics

No response

LCD/Controller

No response

Other add-ons

No response

Bed Leveling

UBL Bilinear mesh

Your Slicer

Cura

Host Software

None

Don't forget to include

Additional information & file uploads

Configs.zip

thisiskeithb commented 5 months ago

Can not compile for Monoprice Maker Select V@ using latest bugfix.

Your configs are not up to date with current bugfix-2.1.x, but they compile fine:

Linking .pio/build/sanguino1284p_optimized/firmware.elf
Checking size .pio/build/sanguino1284p_optimized/firmware.elf
Advanced Memory Usage is available via "PlatformIO Home > Project Inspect"
RAM:   [====      ]  38.8% (used 6364 bytes from 16384 bytes)
Flash: [========= ]  88.7% (used 112594 bytes from 126976 bytes)
Building .pio/build/sanguino1284p_optimized/firmware.hex
================================== [SUCCESS] Took 20.46 seconds ==================================

Environment              Status    Duration
-----------------------  --------  ------------
sanguino1284p_optimized  SUCCESS   00:00:20.462
=================================== 1 succeeded in 00:00:20.462 ===================================
ellensp commented 5 months ago

this is not possible

1) tried your configs, they build fine 2) ENCODER_5X_STEPS_PER_SEC is automatically added in code

https://github.com/MarlinFirmware/Marlin/blob/bugfix-2.1.x/Marlin/src/inc/Conditionals_adv.h#L879-L882

#if ENABLED(ENCODER_RATE_MULTIPLIER)
  #ifndef ENCODER_5X_STEPS_PER_SEC
    #define ENCODER_5X_STEPS_PER_SEC 0
  #endif

and #define ENCODER_RATE_MULTIPLIER is in Your Configuration_adv.h

william-orange commented 5 months ago

And yet on my end it does not build. I added #define ENCODER_5X_STEPS_PER_SEC 15 // (steps/s) Encoder rate for 5x speed around line 1486 (before the one for 10X) in my configuration_adv.h and I can now compile.

thisiskeithb commented 5 months ago

Your copy of Marlin may be broken.

Download a fresh copy of bugfix-2.1.x, apply/migrate your config (or use the Wanhao Duplicator i3 2.1 bugfix-2.1.x. example config if you didn't change anything) and you'll be set.

This Issue Queue is for Marlin bug reports and development-related issues, and we prefer not to handle user-support questions here. (As noted on this page.) For best results getting help with configuration and troubleshooting, please use the following resources:

github-actions[bot] commented 3 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.