search

MarlinFirmware / Marlin

Marlin is an optimized firmware for RepRap 3D printers based on the Arduino platform. Many commercial 3D printers come with Marlin installed. Check with your vendor if you need source code for your specific machine.
https://marlinfw.org
GNU General Public License v3.0
16.32k stars 19.25k forks source link

[BUG] Filament load/unload for DGUS_LCD_UI_MKS is tied to HAS_PID_HEATING instead of DGUS_FILAMENT_LOADUNLOAD #27508

Open vehystrix opened 3 weeks ago

vehystrix commented 3 weeks ago

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

I swapped from PID to MPC temperature control, and suddenly I got a bunch of build errors. Upon investigating, it seems that the filament load/unload code for a DGUS MKS screen has gotten tied to PID temperature control, instead of the original DGUS_FILAMENT_LOADUNLOAD define. The offending commit is ac4fefa, I suspect that when cleaning up the DGUS code, the wrong #if was retained.

Changing line 81 of the DGUSScreenHandler.h file to #if ENABLED(DGUS_FILAMENT_LOADUNLOAD) fixed the build errors for me

Bug Timeline

No response

Expected behavior

No response

Actual behavior

No response

Steps to Reproduce

No response

Version of Marlin Firmware

2.1.2.4

Printer model

No response

Electronics

No response

LCD/Controller

No response

Other add-ons

No response

Bed Leveling

None

Your Slicer

None

Host Software

None

Don't forget to include

Additional information & file uploads

Configuration.zip