MarlinFirmware / Marlin

Marlin is an optimized firmware for RepRap 3D printers based on the Arduino platform. Many commercial 3D printers come with Marlin installed. Check with your vendor if you need source code for your specific machine.
https://marlinfw.org
GNU General Public License v3.0
16.19k stars 19.22k forks source link

When using offset for the probe to the extruder, if there is a decimal place the compiler errors #3063

Closed wolfstep closed 8 years ago

wolfstep commented 8 years ago

When I was compiling the new RC3 firmware and had a decimal place in the offsets the compiler wont work. It only accepts whole numbers claiming there is no place holder for it. rev 1.0.2 had no issues. I attached my config.h file for your perusal. Really frustrating. Lucky the small decimal can be rounded up or down, but really should be able to use the tenths column.

Configuration .txt

Blue-Marlin commented 8 years ago

That's exactly the reason for having the warning directly above. The c preprocessor can't calculate with floats.

thinkyhead commented 8 years ago

@wolfstep Bed leveling will not be affected in any perceptible way if the XY position that actually gets probed is off by under 1mm. So just input the whole values that are closest to the actual position.

jbrazio commented 8 years ago

Just one remark: when deciding which points you'll setup for the auto leveling points, you have to think not about the nozzle position but about the probe position, i.e. when you tell Marlin to probe (10,10) it's not the nozzle that will be centered at (10,10) but instead the probe, that's one of the reasons behind the offset.

thinkyhead commented 8 years ago

Hopefully we'll have some time to write up better Marlin documentation and gather it all into a good place. The documentation that other firmware projects are producing are putting Marlin to shame.

jbrazio commented 8 years ago

maybe getting offtopic.. @thinkyhead the wiki feature here at Github is not enough ? Your your idea is to start a MarlinDocumentation and produce real "documentation" using LaTeX and such ?

thinkyhead commented 8 years ago

@jbrazio Well, our original concept was to put up a MediaWiki site with a distinctive url marlinfirmware.org. I spent dozens of hours there writing up documentation, mainly working on the individual GCodes and getting a start on tricky topics like configuration, calibration, auto bed leveling, etc. Unfortunately the individual who set up the wiki was inaccessible and unhelpful, so I was the only person who could edit it. Fortunately most of the content was saved, copied to the Marlin wiki here on Github. But it remains incomplete.

I would be happy if we were to simply continue to work on the documentation and fill it out, make it as complete as possible. I don't know how it is that other firmware projects have such an easy time getting these things together. The documentation for Smoothie is particularly nice. I would like to think that Marlin can do just as well, but there is no one really "spearheading" these efforts.

jbrazio commented 8 years ago

Ok I spent sometime around this and I may have found a solution, I hope at end of today (I'm in UTC) to open a dedicated issue on the bug tracker so we can start the discussion there and build something.

jbrazio commented 8 years ago

Continues at #3088

github-actions[bot] commented 2 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.