MarlinFirmware / Marlin

Marlin is an optimized firmware for RepRap 3D printers based on the Arduino platform. Many commercial 3D printers come with Marlin installed. Check with your vendor if you need source code for your specific machine.
https://marlinfw.org
GNU General Public License v3.0
16.28k stars 19.23k forks source link

Set MANUAL_Z_HOME_POS for deltas with EEPROM #4061

Closed superlou closed 6 years ago

superlou commented 8 years ago

I've had a lot of luck using the Escher 3D wizard for a delta printer to calibrate endstop corrections and rod lengths. The output of the wizard looks like the following:

M665 R172.11 L355.00
M666 X-0.00 Y0.00 Z-0.34
; Set homed height 299.88mm in config.h

The first two commands can be entered easily over a terminal and saved via M500, but the last one requires opening up the IDE, recompiling, and uploading to the controller. It's not unfeasible, but a little tedious. Is there already a way to specify this parameter and save/load it from EEPROM? If so, I'll reach out to Escher about updating the wizard. If not, could this become a feature down the road?

LVD-AC commented 7 years ago

This can be easily achieved by changing home_offset[Z_AXIS];

the delta height used in calculations= MANUAL_Z_HOME_POS DELTA_HEIGHT + home_offset[Z_AXIS]

home_offset[X_AXIS and Y_AXIS] have no meaning on delta machines, so it could be a good idea to disable M206 and M428 on deltas.

If you want it a bit more structured:

In configuration.h ... add in delta settings:

define DELTA_HEIGHT 270 //mm

... and change:

define MANUAL_Z_HOME_POS DELTA_HEIGHT

In marlin_main.cpp: ... after: inline void gcode_M665() { ... add: if (code_seen('H')) home_offset[Z_AXIS] = code_value_linear_units()- DELTA_HEIGHT;

And in configuration.store.cpp: ... change: SERIAL_ECHOLNPGM("Delta settings: L=diagonal_rod, R=radius, H=height, ... ... and after: SERIAL_ECHOPAIR(" R", delta_radius); ... add: SERIAL_ECHOPAIR(" H", DELTA_HEIGHT + home_offset[Z_AXIS]);

done (#4022)

These changes are needed for calibration routine #6182

boelle commented 7 years ago

@thinkyhead can we close this one since a PR has been submitted?

LVD-AC commented 7 years ago

May be closed since this feature was incorporated in marlin 1.1.0

github-actions[bot] commented 2 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.