Closed ghost closed 8 years ago
Just tried Stable Release 1.0.2 and it works fine. Curious what makes RCBugFix not work.
Did further testing, tried flashing RC6 all the way down to RC1 and RC1 connects. Looks like something changed between RC1 and RC2 that is causing it.
Found the pull request that broke it:
https://github.com/MarlinFirmware/Marlin/pull/2433
Undid those changes and Printrboard works fine.
How did I miss this one?!
Thank you for providing a fix. It makes sense. Sometimes changes are made by contributors, but no one remains who knows the rationale for the way things were. Hopefully with better commenting of things like this, we can avoid such naive breaking changes in the future.
Incidentally, is it possible to simply do this for these cases?
#define USBCON AT90USB
… (or in pins.h
) …
#ifdef AT90USB
#define USBCON AT90USB
#endif
(i.e., Is AT90USB
defined and set to these same values?)
@thinkyhead can we close this one ?
@jbrazio Let's keep this open until the needed changes have been made.
have the changes been made?
@boelle, don't see a fix
@darrelhunt, are you working on PR against RCBugFix ?
I'm not entirely sure whether to simply revert the changes, or if we need to still follow the general idea, but in a smarter way. I haven't delved into this area enough to fully understand the requirements. I think @AnHardt or perhaps @Blue-Marlin may have more insight on this one.
Thank you @darrelhunt !
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Update to RC6, everything uploaded fine, it just won't connect. Tried Repetier Host and Octoprint.
Appears to be a Marlin-specific issue, if I install Repetier Firmware, I am able to connect without a problem.
Configuration.h
``` cpp /** * Marlin 3D Printer Firmware * Copyright (C) 2016 MarlinFirmware [https://github.com/MarlinFirmware/Marlin] * * Based on Sprinter and grbl. * Copyright (C) 2011 Camiel Gubbels / Erik van der Zalm * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation, either version 3 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program. If not, see