MarlinFirmware / Marlin

Marlin is an optimized firmware for RepRap 3D printers based on the Arduino platform. Many commercial 3D printers come with Marlin installed. Check with your vendor if you need source code for your specific machine.
https://marlinfw.org
GNU General Public License v3.0
16.04k stars 19.15k forks source link

AUTO BED LEVELING FEATURE not working with latest RCBugFix #4802

Closed renzaaa closed 7 years ago

renzaaa commented 7 years ago

Not working with AUTO_BED_LEVELING_GRID_POINTS 2 (probing 2 points and gantry crash to the x-max side). Not working with AUTO_BED_LEVELING_GRID_POINTS 3 (probing 6 points and gantry crash to the x-max side).

Mugga6315 commented 7 years ago

Same for me, like already posted here: https://github.com/MarlinFirmware/Marlin/issues/4662#issuecomment-246774815

thinkyhead commented 7 years ago

@renzaaa Sorry about that! I've been doing a lot of patches in the last couple days and probably mistyped something. Can you post your configuration so I can test with exactly your settings? Thanks!

thinkyhead commented 7 years ago

See if this change to line 3454 of Marlin_main.cpp makes any difference:

-       for (uint8_t xCount = xStart; xCount != xStop; xCount += xInc) {
+       for (int8_t xCount = xStart; xCount != xStop; xCount += xInc) {
thinkyhead commented 7 years ago

Also… line 3434…

-     uint8_t zig = auto_bed_leveling_grid_points & 1; //always end at [RIGHT_PROBE_BED_POSITION, BACK_PROBE_BED_POSITION]
+     bool zig = auto_bed_leveling_grid_points & 1; //always end at [RIGHT_PROBE_BED_POSITION, BACK_PROBE_BED_POSITION]
Mugga6315 commented 7 years ago

Works with the changes! Thanks. But the other issue I referred to, in my post stays (x-axis seems to be straight, but y-axis movement is higher at the back and almost crashing into bed in the front)

thinkyhead commented 7 years ago

@Mugga6315 See my earlier reply on that issue.

renzaaa commented 7 years ago

@thinkyhead Working now. Thanks.

github-actions[bot] commented 2 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.