search

MarlinFirmware / Marlin

Marlin is an optimized firmware for RepRap 3D printers based on the Arduino platform. Many commercial 3D printers come with Marlin installed. Check with your vendor if you need source code for your specific machine.
https://marlinfw.org
GNU General Public License v3.0
16.19k stars 19.21k forks source link

UBL & Mesh Editing requirement? #6191

Closed ghost closed 7 years ago

ghost commented 7 years ago

If UBL_G26_MESH_EDITING is required to run G29, then why not a sanity check?

I loaded the latest RCBugFix tonight and had AUTO_BED_LEVELING_UBL enabled. G29 simply does nothing but report back ok.

      #if PLANNER_LEVELING && !ENABLED(AUTO_BED_LEVELING_UBL) || ENABLED(AUTO_BED_LEVELING_UBL) && ENABLED(UBL_G26_MESH_EDITING)
        case 29: // G29 Detailed Z probe, probes the bed at 3 or more points,
                 // or provides access to the UBL System if enabled.
          gcode_G29();
          break;
ghost commented 7 years ago

Something else is going on because I saw that I do have the mesh edit enabled.

I see what happened. I made an error in configuration.h. UBL_G26_MESH_EDITING was still UBL_MESH_EDIT_ENABLED.

Corrected it and it works.

thinkyhead commented 7 years ago

Yep! Somehow in my sleepless state I forgot to remove that condition from the UBL_G29 precursor. It's patched now. Also added a sanity check I forgot to include.

EDIT: or, now.

github-actions[bot] commented 2 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.