MarlinFirmware / Marlin

Marlin is an optimized firmware for RepRap 3D printers based on the Arduino platform. Many commercial 3D printers come with Marlin installed. Check with your vendor if you need source code for your specific machine.
https://marlinfw.org
GNU General Public License v3.0
16.26k stars 19.23k forks source link

Compile error with SKEW_CORRECTION #8709

Closed DaveAhrendt closed 6 years ago

DaveAhrendt commented 6 years ago

Compiling with Arduino IDE 1.9.0-beta and Marlin bugfix 2.0 from 12/6. Was running well and decided to see what skew correction was about. Just enabling #define SKEW_CORRECTION with default values causes a compile error or more likely a linker error.

C:\Users\Dave\AppData\Local\Temp\ccWPadut.ltrans8.ltrans.o: In function `MarlinSettings::save()':
ccWPadut.ltrans8.o:(.text+0x706): undefined reference to `Planner::xy_skew_factor'
ccWPadut.ltrans8.o:(.text+0x708): undefined reference to `Planner::xy_skew_factor'
ccWPadut.ltrans8.o:(.text+0x71e): undefined reference to `Planner::xz_skew_factor'
ccWPadut.ltrans8.o:(.text+0x720): undefined reference to `Planner::xz_skew_factor'
ccWPadut.ltrans8.o:(.text+0x736): undefined reference to `Planner::yz_skew_factor'
ccWPadut.ltrans8.o:(.text+0x738): undefined reference to `Planner::yz_skew_factor'
collect2.exe: error: ld returned 1 exit status
Using library U8glib at version 1.19.1 in folder: C:\Users\Dave\Documents\Arduino\libraries\U8glib 
exit status 1
Error compiling for board Arduino/Genuino Mega or Mega 2560.

Further information: Using the default config. files from the .zip file things compile OK with skew_correction enabled. Using the Folger I3-2020 (changed to use BOARD_RAMPS_14_EFB for motherboard) I get the compile error with skew_correction enabled. Tried with UBL disabled - same error.

PolloPequeno commented 6 years ago

Just a heads up that Skew isn't working with UBL enabled (I'm using 1.1.X_bugfix and it's compiling fine). See #8632

thinkyhead commented 6 years ago

The issue shown here should now be fixed. A fix for skew with UBL is pending at #8729

github-actions[bot] commented 3 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.