MarlinFirmware / Marlin

Marlin is an optimized firmware for RepRap 3D printers based on the Arduino platform. Many commercial 3D printers come with Marlin installed. Check with your vendor if you need source code for your specific machine.
https://marlinfw.org
GNU General Public License v3.0
16.22k stars 19.22k forks source link

[2.0.x] With newest firmware printer seems to work in a 'simulated mode' #9350

Closed GMagician closed 6 years ago

GMagician commented 6 years ago

After update my firmware with latest PR the printer doesn't work anymore.

Al manual commands works as expected but once I start printing from repetier. gcode is executed in a 'simulation mode'. Doesn't wait temperature on bed nor hotend, gcode advance (with cold extrusion prevention fault) but axes are stopped

GMagician commented 6 years ago

If seems that new implementation of _BV is not working as expected

GMagician commented 6 years ago

@thinkyhead don't tell me why but g800 P1 set codebits to 0xFFFF8000 Maybe is only debug mode that display a wrong value...

benlye commented 6 years ago

There's definitely something wonky with the parser since #9327. Also, trying to compile with FASTER_GCODE_PARSER disabled fails:

In file included from Marlin\src\gcode/gcode.h:250:0,
from Marlin\src\Marlin.cpp:49:
Marlin\src\gcode/parser.h: In static member function 'static bool GCodeParser::seen(char)':
Marlin\src\gcode/parser.h:147:43: error: 'valid_float' was not declared in this scope
if (b) value_ptr = valid_float(&p[1]) ? &p[1] : (char*)NULL;
^
benlye commented 6 years ago

Reverting 80d3ded89523b741cec40c43cc09673411eaf168 and 399bca316a5abe64f18ce202699822fcd9738b98 seem to make the parsing problem go away.

GMagician commented 6 years ago

@thinkyhead I confirm, new _BV implementation doesn't works as expected. I tried different fix but it seems that compiler works with signed variables

Allted commented 6 years ago

Just to re-enforce this I am seeing the same sort of issues.

GMagician commented 6 years ago

It has no sense to keep open more issues about the same problem. Since #9366 better resume who is "guilty". I close mine

github-actions[bot] commented 3 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.