search

MarlinFirmware / MarlinDocumentation

Marlin Firmware Documentation Project
https://marlinfw.org
GNU General Public License v3.0
366 stars 763 forks source link

Add documentation on geometry report #496

Closed 0r31 closed 1 year ago

0r31 commented 1 year ago

Hi,

As stated in the title, this PR add documentation regarding the optional geometry report the M115 gcode command can provide.

I also created a PR in Octoprint to handle this in the virtual printer (https://github.com/OctoPrint/OctoPrint/pull/4799).

thinkyhead commented 1 year ago

The axes IJKUVW should be left out of the geometry report if they're not enabled. Are you seeing them being included in the report even when they're not enabled? If not, we should change the description that says:

Please note `i,j,k,u,v,w` are used for additional axes. (These are initialized to 0 if not used.)
0r31 commented 1 year ago

Hi @thinkyhead ,

You are totally right i missed the LIST_N(N, ...) macro usage as i am working on a Marlin version prior to https://github.com/MarlinFirmware/Marlin/commit/52096599b30d4d49b3fee61a85102054a2d298d8. My bad.

Will update the PR accordingly.

thisiskeithb commented 1 year ago

The axes IJKUVW should be left out of the geometry report if they're not enabled.

Just checked and they’re left out. Here’s the output from my MK3:

area:{full:{min:{x:0.00,y:-4.00,z:0.15},max:{x:255.00,y:212.50,z:210.00}},work:{min:{x:0.00,y:0.00,z:0.15},max:{x:255.00,y:212.50,z:210.00}}}