search

MarlinFirmware / MarlinDocumentation

Marlin Firmware Documentation Project
https://marlinfw.org
GNU General Public License v3.0
366 stars 764 forks source link

Issue with K-factor Calibration Tool #532

Closed kendrickxy closed 6 months ago

kendrickxy commented 7 months ago

When I enter a value that causes an error, the software won't let me generate the G-code, even after correction. i.g:

image image

I get this error. So I change the K-Factor Stepping to 0.002, but I'm still unable to generate the G-code.

The only solution I've found is to reload the page and enter the data once again.

kendrickxy commented 7 months ago

Well I guess changing the html code is also a work around 😄

thisiskeithb commented 7 months ago

The form doesn't re-validate settings until you tab/click into another textbox.

kendrickxy commented 7 months ago

I've tried, Textbox, Dropbox, checkbox. Unfortunately doesn't fix the Generate button for me.

thisiskeithb commented 7 months ago

Which OS & browser are you using?

thinkyhead commented 7 months ago

Unable to reproduce…

image

Floating point maths can sometimes be imprecise. So it's possible the test for even divisibility fails on some devices with wonky math libraries. Try different browsers and operating systems to see if they do the same thing. Meanwhile, we can try adjusting this test to see if adding parseInt or other tricks help.

kendrickxy commented 6 months ago

I am using Edge, but in the video I tried Chrome.

https://github.com/MarlinFirmware/MarlinDocumentation/assets/16179839/5db2609e-05cd-405a-881a-465f2d52b322

Am I doing it wrong?

thinkyhead commented 6 months ago

The buttons should be fixed now.