Typo in src/clib/u8g.h#L451

ellensp commented 9 months ago

u8g.h Has

/* OLED 128x64 Display with SSD1309 Controller - Fast Single Page */
extern u8g_dev_t u8g_dev_ssd1309_128x64_f_sw_spi;
extern u8g_dev_t u8g_dev_ssd1309_128x64_f_hw_spi;
extern u8g_dev_t u8g_dev_ssd1309_128x64_f_sw_spi;

But last line should be

extern u8g_dev_t u8g_dev_ssd1309_128x64_f_i2c;

Also in platformio the download https://dl.registry.platformio.org/libraries/6b/fa/5589b9bdde2f8434f3753af1e086f7415ace71f9e7e05c486d3f3e656675/U8glib-HAL-0.5.3.tar.gz the updated u8g.h is not present
It can also be seen as missing in .pio/libdeps/{env}/U8glib-HAL/src/clib/u8g.h which I cannot explain, its there if I download the library manually from github

dbuezas commented 9 months ago

Oh no, that's my fault. I don't have a computer at the moment to make a new PR, sorry for that.

thisiskeithb commented 9 months ago

There may have been some force-pushing going on since https://github.com/MarlinFirmware/U8glib-HAL/commit/e258d50d318d75a36856d86767be4b9b52f50998 and https://github.com/MarlinFirmware/U8glib-HAL/commit/36f76705c570cedf01b315c5927871de324e30dc exist with a "Version 0.5.3" commit title.

I suspect PIO isn't picking up the updated code and another tag (and release?) is in order once this bug has been fixed. cc: @thinkyhead

thinkyhead commented 9 months ago

Oh no, that's my fault.

Mea culpa. The buck stops here. I should have actually done some builds before merging.

MarlinFirmware / U8glib-HAL

Typo in src/clib/u8g.h#L451 #32