Marlyn-Mayienga / SpaceHub-Travellers

This web app works with the real live data from the SpaceX API. It is for a company that provides commercial and scientific space travel services. The application allows users to book rockets and join selected space missions.
1 stars 0 forks source link

Kanban Setup #21

Closed Marlyn-Mayienga closed 2 years ago

Marlyn-Mayienga commented 2 years ago

In this module, we:

This is the link to the repository Kanban board: https://github.com/Marlyn-Mayienga/SpaceHub-Travellers/projects/1 There are three people working on this project. @vigehi , @AlucardSanin and @Marlyn-Mayienga

sja-thedude commented 2 years ago

Required Changes ♻️

Hi Team, This is @sja-thedude your code reviewer.

Good job so far! There are some issues that you still need to work on before you start working on the project but you are almost there!

768070f3-bc9a-4aba-b8bc-25793e00ea1e_text

Highlights

✔️ Good job so far

Required

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me [@sja-thedude] in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Marlyn-Mayienga commented 2 years ago

@sja-thedude we cloned the repository and we received only 20 issues. Any ideas how we could get all 24?

KayLemba commented 2 years ago

STATUS: APPROVED :green_circle: :clap:

Hello @Marlyn-Mayienga @vigehi @AlucardSanin , Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

HIGHLIGHTS:

Now you can merge this branch and move on :1st_place_medal: Happy Coding cheers 🥇 💯

well-1

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.