use type from firebase-admin instead of our own defined type

Marplex / flarebase-auth

Firebase/Admin Auth Javascript Library for Cloudflare Workers

https://dev.to/marplex/firebase-authentication-on-cloudflare-workers-24o3

MIT License

88 stars 14 forks source link

use type from firebase-admin instead of our own defined type #3

Closed ryoppippi closed 8 months ago

ryoppippi commented 1 year ago

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Bug fix
What is the current behavior? (You can also link to an open issue here) Decoded Token is actually includes properties which are not defined in lib/model/token.ts like email_verified etc. So I think it is better to use official type definition

treeder commented 9 months ago

I think the idea of this package is to remove the firebase-admin dependency.

Marplex commented 8 months ago

I think the idea of this package is to remove the firebase-admin dependency.

Exactly, it didn't seem reasonable to add the full firebase-admin dependency just for one model type. I think it's better to manually include the properties when needed.

By the way, this library may still work, but it's been a while since I last used it. If you are using Hono, @hono/firebase-auth is better. It has support for JWT caching and it's well maintained.