Feature/job detail expanded sql - Githubissues

MarquezProject / marquez-web

Marquez Web UI

23 stars 6 forks source link

Feature/job detail expanded sql #24

Closed mell0kat closed 4 years ago

mell0kat commented 4 years ago

expandSQL

Description

User can expand to see full SQL in a Modal. User can copy SQL to clipboard.

Checklist

[x] This PR contains tests (at least one (non-snapshot) test)

mell0kat commented 4 years ago

@jhubley Good catch!

So -- weirdly -- the issue was some extra parentheses in the code that was adding an extra line. Just added a fix (see line 249 of this diff https://github.com/MarquezProject/marquez-web/pull/24/commits/0151d8b110cc24085a01a3e2cc26450f43d4e584#diff-46665bbb0110f32365f8fabb43dc857bL249)

Screen Shot 2019-12-07 at 5 30 03 AM

Going to re-request your review right now