search

MarquezProject / marquez

Collect, aggregate, and visualize a data ecosystem's metadata
https://marquezproject.ai
Apache License 2.0
1.78k stars 320 forks source link

web: Add env variable for setting up the frontend port #2838

Closed bidlako closed 3 months ago

bidlako commented 5 months ago

Replacing the hardcoded port with env variable.

boring-cyborg[bot] commented 5 months ago

Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md).

netlify[bot] commented 5 months ago

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
Latest commit 63e105632f794a67490dccddd99cd49dbbf4d46c
Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/66b64abae3de590008e268b7
wslulciuc commented 3 months ago

@bidlako, changes look good to me, but to merge, you'll need to sign your commits to pass our DCO check.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.77%. Comparing base (9ab3d45) to head (63e1056).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2838 +/- ## ========================================= Coverage 84.77% 84.77% Complexity 1470 1470 ========================================= Files 256 256 Lines 6626 6626 Branches 308 308 ========================================= Hits 5617 5617 Misses 856 856 Partials 153 153 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

boring-cyborg[bot] commented 3 months ago

Great job! Congrats on your first merged pull request in the Marquez project!