Web: encode job name in API requests

dolfinus commented 3 months ago

Problem

After upgrading to 0.48 opening some job details lead to 404 errors. This is because I have job names with slashes, like my/session/name, resulting API query to look like this: http://localhost:8080/api/v1/namespaces/yarn%3A%2F%2Fsomecluster/jobs/my/session/name.execute_insert_into_hadoop_fs_relation_command

But it should be: http://localhost:8080/api/v1/namespaces/yarn%3A%2F%2Fsomecluster/jobs/my%2Fsession%2Fname.execute_insert_into_hadoop_fs_relation_command

Same could be applied to dataset, tag or field names.

Solution

One-line summary:

Urlencode job, dataset, tag and field names while sending API request.

Checklist

[X] You've signed-off your work
[ ] Your changes are accompanied by tests (if relevant)
[X] Your change contains a small diff and is self-contained
[ ] You've updated any relevant documentation (if relevant)
[X] You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
[ ] You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
[ ] You've included a header in any source code files (if relevant)

netlify[bot] commented 3 months ago

Deploy Preview for peppy-sprite-186812 canceled.

Name	Link
Latest commit	49bcd9c59d8b99179c909d9bfddb6206a49b62ad
Latest deploy log	https://app.netlify.com/sites/peppy-sprite-186812/deploys/66b0e33537083f0008684c02

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.47%. Comparing base (94ec22e) to head (49bcd9c).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2866 +/- ## ============================================ + Coverage 84.80% 85.47% +0.67% + Complexity 1469 1228 -241 ============================================ Files 256 213 -43 Lines 6615 5619 -996 Branches 308 268 -40 ============================================ - Hits 5610 4803 -807 + Misses 852 692 -160 + Partials 153 124 -29 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MarquezProject / marquez