MarquezProject / marquez

Collect, aggregate, and visualize a data ecosystem's metadata
https://marquezproject.ai
Apache License 2.0
1.78k stars 320 forks source link

Add migration with on cascade delete constraint #2878

Closed mattwparas closed 3 months ago

mattwparas commented 3 months ago

Problem

Closes: #2871

Solution

I am occasionally running into this #2871 - after reviewing the migrations it appears that a cascade delete constraint was missing. I believe this is a backwards compatible change. The problem manifests itself when the retention job runs, and causes the retention jobs to quit and not continue since it can't move forward.

One-line summary:

Checklist

boring-cyborg[bot] commented 3 months ago

Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md).

netlify[bot] commented 3 months ago

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
Latest commit b6dec32190d381ebca2a9340856b268706a4c721
Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/66c8acf31cc94d00088e71d2
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.28%. Comparing base (ead480b) to head (b6dec32). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2878 +/- ## ========================================= Coverage 83.28% 83.28% Complexity 1477 1477 ========================================= Files 259 259 Lines 6785 6785 Branches 313 313 ========================================= Hits 5651 5651 Misses 977 977 Partials 157 157 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

boring-cyborg[bot] commented 3 months ago

Great job! Congrats on your first merged pull request in the Marquez project!