MarquezProject / marquez

Collect, aggregate, and visualize a data ecosystem's metadata
https://marquezproject.ai
Apache License 2.0
1.78k stars 320 forks source link

Updated event count chip rendering #2916

Closed NisargChokshi45 closed 1 month ago

NisargChokshi45 commented 1 month ago

Problem

👋 Thanks for opening a pull request! Please include a brief summary of the problem your change is trying to solve, or bug fix. If your change fixes a bug or you'd like to provide context on why you're making the change, please link the issue as follows:

Closes: #ISSUE-NUMBER

Solution

Please describe your change as it relates to the problem, or bug fix, as well as any dependencies. If your change requires a database schema migration, please describe the schema modification(s) and whether it's a backwards-incompatible or backwards-compatible change.

Note: All database schema changes require discussion. Please link the issue for context.

One-line summary: Updated event count chip rendering

Checklist

boring-cyborg[bot] commented 1 month ago

Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md).

netlify[bot] commented 1 month ago

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
Latest commit 6ee3286ffc132b2362ccf3de584c31df287d525f
Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/66fed97d3b232b0008a018d4
NisargChokshi45 commented 1 month ago

Hey @wslulciuc @phixMe, can you please review this PR ? If possible, can we also add a label named hacktoberfest in the PR ?

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.10%. Comparing base (9e8e3d3) to head (6ee3286). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2916 +/- ## ========================================= Coverage 83.10% 83.10% Complexity 1487 1487 ========================================= Files 264 264 Lines 6849 6849 Branches 315 315 ========================================= Hits 5692 5692 Misses 1002 1002 Partials 155 155 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wslulciuc commented 1 month ago

@NisargChokshi45, done! I've also added @phixMe as the reviewer.

boring-cyborg[bot] commented 1 month ago

Great job! Congrats on your first merged pull request in the Marquez project!