Closed Kess220 closed 1 month ago
Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md).
Name | Link |
---|---|
Latest commit | e2f20f4876c0079f43ce551da660d9e2005416c3 |
Latest deploy log | https://app.netlify.com/sites/peppy-sprite-186812/deploys/6717f05cef6f280008da3296 |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 81.12%. Comparing base (
d9ec368
) to head (e2f20f4
). Report is 5 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This pull request includes several refactoring changes to the
DatasetDetailPage
andJobDetailPage
components to clean up the code and remove unused imports and methods. The most important changes involve simplifying the import statements and removing the dialog-related code.Refactoring changes:
web/src/components/datasets/DatasetDetailPage.tsx
: Simplified import statements by combining multiple imports from@mui/material
into a single line and removed unused imports (Dialog
,alpha
). [1] [2]web/src/components/datasets/DatasetDetailPage.tsx
: Removed unused props (display
,deleteDataset
,dialogToggle
) and corresponding dialog-related code. [1] [2]web/src/components/jobs/JobDetailPage.tsx
: Simplified import statements by removing unused imports (Dialog
,alpha
). [1] [2]web/src/components/jobs/JobDetailPage.tsx
: Removed unused props (deleteJob
,dialogToggle
,display
) and corresponding dialog-related code. [1] [2]Type of Change
Checklist
Commit Description
Refactor: Remove delete buttons from JobDetailPage and DatasetDetailPage
Modified Files
JobDetailPage.tsx
DatasetDetailPage.tsx
Changes Made