MarquezProject / marquez

Collect, aggregate, and visualize a data ecosystem's metadata
https://marquezproject.ai
Apache License 2.0
1.78k stars 320 forks source link

fix: Correct SQL query pagination for DatasetVersion findAll method #2945

Closed inanalper closed 4 weeks ago

inanalper commented 4 weeks ago

Problem

https://github.com/MarquezProject/marquez/issues/2944

Closes: #2944

Solution

Moved the misplaced LIMIT and OFFSET statements.

Checklist

boring-cyborg[bot] commented 4 weeks ago

Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md).

netlify[bot] commented 4 weeks ago

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
Latest commit e112c55bdf6a6f95af9e2a600c2cacd6b4fbf141
Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/671980fdf823fb0008ee78a2
codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.16%. Comparing base (2ffe5aa) to head (e112c55). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2945 +/- ## ========================================= Coverage 81.16% 81.16% Complexity 1506 1506 ========================================= Files 268 268 Lines 7363 7363 Branches 329 329 ========================================= Hits 5976 5976 Misses 1226 1226 Partials 161 161 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

boring-cyborg[bot] commented 4 weeks ago

Great job! Congrats on your first merged pull request in the Marquez project!