feature: Better handling of missing environment variables in setupProxy.js file

arturowczarek commented 3 weeks ago

Problem

At some point (August 2024) setupProxy.js started using WEB_PORT. The related docker compose configuration files not always have it updated. Without this variable set, the containers start but listen on undefined port. The users can't use the stack and are confused why. Here's an example of a fix of this king of problem https://github.com/OpenLineage/OpenLineage/pull/3192

Solution

When some important environment variable is missing the application should stop and the user should stay informed about that they should do next.

One-line summary:

Checklist

[X] You've signed-off your work
[ ] Your changes are accompanied by tests (if relevant)
[X] Your change contains a small diff and is self-contained
[ ] You've updated any relevant documentation (if relevant)
[ ] You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
[ ] You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
[ ] You've included a header in any source code files (if relevant)

boring-cyborg[bot] commented 3 weeks ago

Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md).

netlify[bot] commented 3 weeks ago

Deploy Preview for peppy-sprite-186812 canceled.

Name	Link
Latest commit	d05152930663db4169ac3e73fb57e26a177a8fa2
Latest deploy log	https://app.netlify.com/sites/peppy-sprite-186812/deploys/671f7a733094ad00085564d1

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.19%. Comparing base (9e2e9b4) to head (d051529). Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2956 +/- ## ========================================= Coverage 81.19% 81.19% Complexity 1505 1505 ========================================= Files 268 268 Lines 7358 7358 Branches 325 325 ========================================= Hits 5974 5974 Misses 1226 1226 Partials 158 158 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

boring-cyborg[bot] commented 3 weeks ago

Great job! Congrats on your first merged pull request in the Marquez project!

MarquezProject / marquez