MarquezProject / marquez

Collect, aggregate, and visualize a data ecosystem's metadata
https://marquezproject.ai
Apache License 2.0
1.78k stars 320 forks source link

Postgres bind port forces 5432 - regression bug #2958

Open seanmullane opened 3 weeks ago

seanmullane commented 3 weeks ago

When trying to start Marquez 0.50.0 with the default Postgres port 5432 and another Postgres instance already running on 5432, Marquez fails to come up, citing this error: ERROR: for marquez-db Cannot start service db: driver failed programming external connectivity on endpoint marquez-db (17965108eb9858b73cd22cad4a76ec003b239a40692ef0f32e03053f0022a365): Error starting userland proxy: listen tcp4 0.0.0.0:5432: bind: address already in use

It appears this is a regression related to https://github.com/MarquezProject/marquez/issues/1956

docker-compose.yml contains the lines: `db: image: postgres:14 container_name: marquez-db ports:

Having port twice prevents the random assignment that was added in this PR: https://github.com/MarquezProject/marquez/pull/2000

This looks like it was fixed in 0.23.0 and the regression appeared in 0.26.0 when 5432 was changed back to 5432:5432

wslulciuc commented 3 weeks ago

Thanks for reporting this @seanmullane! I've added arg --db-port to our docker/up.sh allowing you to override the postgres port if there's already an instance listening on 5432, see https://github.com/MarquezProject/marquez/pull/2961